hippi: Remove unused hippi_neigh_setup_dev

[PATCH net-next] hippi: Remove unused hippi_neigh_setup_dev

Posted by linux@treblig.org 1 year ago

From: "Dr. David Alan Gilbert" <linux@treblig.org>

hippi_neigh_setup_dev() has been unused since
commit e3804cbebb67 ("net: remove COMPAT_NET_DEV_OPS")

Remove it.

(I'm a little suspicious it's the only setup call removed
by that previous commit?)

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 include/linux/hippidevice.h |  1 -
 net/802/hippi.c             | 15 ---------------
 2 files changed, 16 deletions(-)

diff --git a/include/linux/hippidevice.h b/include/linux/hippidevice.h
index 07414c241e65..404bd5b2b4fc 100644
--- a/include/linux/hippidevice.h
+++ b/include/linux/hippidevice.h
@@ -33,7 +33,6 @@ struct hippi_cb {
 
 __be16 hippi_type_trans(struct sk_buff *skb, struct net_device *dev);
 int hippi_mac_addr(struct net_device *dev, void *p);
-int hippi_neigh_setup_dev(struct net_device *dev, struct neigh_parms *p);
 struct net_device *alloc_hippi_dev(int sizeof_priv);
 #endif
 
diff --git a/net/802/hippi.c b/net/802/hippi.c
index 1997b7dd265e..5e02ec1274a1 100644
--- a/net/802/hippi.c
+++ b/net/802/hippi.c
@@ -126,21 +126,6 @@ int hippi_mac_addr(struct net_device *dev, void *p)
 }
 EXPORT_SYMBOL(hippi_mac_addr);
 
-int hippi_neigh_setup_dev(struct net_device *dev, struct neigh_parms *p)
-{
-	/* Never send broadcast/multicast ARP messages */
-	NEIGH_VAR_INIT(p, MCAST_PROBES, 0);
-
-	/* In IPv6 unicast probes are valid even on NBMA,
-	* because they are encapsulated in normal IPv6 protocol.
-	* Should be a generic flag.
-	*/
-	if (p->tbl->family != AF_INET6)
-		NEIGH_VAR_INIT(p, UCAST_PROBES, 0);
-	return 0;
-}
-EXPORT_SYMBOL(hippi_neigh_setup_dev);
-
 static const struct header_ops hippi_header_ops = {
 	.create		= hippi_header,
 };
-- 
2.47.1

Re: [PATCH net-next] hippi: Remove unused hippi_neigh_setup_dev

Posted by Simon Horman 1 year ago

On Sun, Dec 15, 2024 at 02:26:18AM +0000, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> hippi_neigh_setup_dev() has been unused since
> commit e3804cbebb67 ("net: remove COMPAT_NET_DEV_OPS")
> 
> Remove it.
> 
> (I'm a little suspicious it's the only setup call removed
> by that previous commit?)
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Hi David,

There is a dangling comment referring to hippi_neigh_setup_dev
in hippi_setup().

	/*
	 * HIPPI doesn't support broadcast+multicast and we only use
	 * static ARP tables. ARP is disabled by hippi_neigh_setup_dev.
	 */

Could you fix that up too?

pw-bot: changes-requested

Re: [PATCH net-next] hippi: Remove unused hippi_neigh_setup_dev

Posted by Dr. David Alan Gilbert 1 year ago

* Simon Horman (horms@kernel.org) wrote:
> On Sun, Dec 15, 2024 at 02:26:18AM +0000, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > hippi_neigh_setup_dev() has been unused since
> > commit e3804cbebb67 ("net: remove COMPAT_NET_DEV_OPS")
> > 
> > Remove it.
> > 
> > (I'm a little suspicious it's the only setup call removed
> > by that previous commit?)
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> 
> Hi David,
> 
> There is a dangling comment referring to hippi_neigh_setup_dev
> in hippi_setup().
> 
> 	/*
> 	 * HIPPI doesn't support broadcast+multicast and we only use
> 	 * static ARP tables. ARP is disabled by hippi_neigh_setup_dev.
> 	 */
> 
> Could you fix that up too?

I saw that, and it raised the suspicion that I mentioned in the
commit message; is that code relying on the uncalled, removed
function to disable ARPs?

Dave

> pw-bot: changes-requested
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH net-next] hippi: Remove unused hippi_neigh_setup_dev

Posted by Dr. David Alan Gilbert 1 year ago

Note the hippi list address bounces:

<linux-hippi@sunsite.dk>:
Sorry, no mailbox here by that name. (#5.1.1)

Dave

* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> hippi_neigh_setup_dev() has been unused since
> commit e3804cbebb67 ("net: remove COMPAT_NET_DEV_OPS")
> 
> Remove it.
> 
> (I'm a little suspicious it's the only setup call removed
> by that previous commit?)
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  include/linux/hippidevice.h |  1 -
>  net/802/hippi.c             | 15 ---------------
>  2 files changed, 16 deletions(-)
> 
> diff --git a/include/linux/hippidevice.h b/include/linux/hippidevice.h
> index 07414c241e65..404bd5b2b4fc 100644
> --- a/include/linux/hippidevice.h
> +++ b/include/linux/hippidevice.h
> @@ -33,7 +33,6 @@ struct hippi_cb {
>  
>  __be16 hippi_type_trans(struct sk_buff *skb, struct net_device *dev);
>  int hippi_mac_addr(struct net_device *dev, void *p);
> -int hippi_neigh_setup_dev(struct net_device *dev, struct neigh_parms *p);
>  struct net_device *alloc_hippi_dev(int sizeof_priv);
>  #endif
>  
> diff --git a/net/802/hippi.c b/net/802/hippi.c
> index 1997b7dd265e..5e02ec1274a1 100644
> --- a/net/802/hippi.c
> +++ b/net/802/hippi.c
> @@ -126,21 +126,6 @@ int hippi_mac_addr(struct net_device *dev, void *p)
>  }
>  EXPORT_SYMBOL(hippi_mac_addr);
>  
> -int hippi_neigh_setup_dev(struct net_device *dev, struct neigh_parms *p)
> -{
> -	/* Never send broadcast/multicast ARP messages */
> -	NEIGH_VAR_INIT(p, MCAST_PROBES, 0);
> -
> -	/* In IPv6 unicast probes are valid even on NBMA,
> -	* because they are encapsulated in normal IPv6 protocol.
> -	* Should be a generic flag.
> -	*/
> -	if (p->tbl->family != AF_INET6)
> -		NEIGH_VAR_INIT(p, UCAST_PROBES, 0);
> -	return 0;
> -}
> -EXPORT_SYMBOL(hippi_neigh_setup_dev);
> -
>  static const struct header_ops hippi_header_ops = {
>  	.create		= hippi_header,
>  };
> -- 
> 2.47.1
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH net-next] hippi: Remove unused hippi_neigh_setup_dev

Posted by Simon Horman 1 year ago

On Sun, Dec 15, 2024 at 02:28:01AM +0000, Dr. David Alan Gilbert wrote:
> Note the hippi list address bounces:
> 
> <linux-hippi@sunsite.dk>:
> Sorry, no mailbox here by that name. (#5.1.1)

I suggest submitting a patch to MAINTAINERS to drop the that ML from there.
In general, patches for MAINTAINERS can be targeted at net.

Re: [PATCH net-next] hippi: Remove unused hippi_neigh_setup_dev

Posted by Dr. David Alan Gilbert 1 year ago

* Simon Horman (horms@kernel.org) wrote:
> On Sun, Dec 15, 2024 at 02:28:01AM +0000, Dr. David Alan Gilbert wrote:
> > Note the hippi list address bounces:
> > 
> > <linux-hippi@sunsite.dk>:
> > Sorry, no mailbox here by that name. (#5.1.1)
> 
> I suggest submitting a patch to MAINTAINERS to drop the that ML from there.
> In general, patches for MAINTAINERS can be targeted at net.

Thanks,

Just sent, see 20241216165605.63700-1-linux@treblig.org

Dave

-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/