[PATCH v7 2/7] dt-bindings: iio: accel: adxl345: make interrupts not a required property

Lothar Rubusch posted 7 patches 1 year ago
There is a newer version of this series
[PATCH v7 2/7] dt-bindings: iio: accel: adxl345: make interrupts not a required property
Posted by Lothar Rubusch 1 year ago
Remove interrupts from the list of required properties. The ADXL345
does not need interrupts for basic accelerometer functionality. The
sensor offers optional events which can be indicated on one of two
interrupt lines.

Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
---
 Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
index 280ed479e..bc46ed00f 100644
--- a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
+++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
@@ -40,7 +40,6 @@ properties:
 required:
   - compatible
   - reg
-  - interrupts
 
 allOf:
   - $ref: /schemas/spi/spi-peripheral-props.yaml#
-- 
2.39.5
Re: [PATCH v7 2/7] dt-bindings: iio: accel: adxl345: make interrupts not a required property
Posted by Krzysztof Kozlowski 1 year ago
On Fri, Dec 13, 2024 at 09:19:04PM +0000, Lothar Rubusch wrote:
> Remove interrupts from the list of required properties. The ADXL345
> does not need interrupts for basic accelerometer functionality. The
> sensor offers optional events which can be indicated on one of two
> interrupt lines.
> 
> Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
> ---
>  Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml | 1 -
>  1 file changed, 1 deletion(-)

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Re: [PATCH v7 2/7] dt-bindings: iio: accel: adxl345: make interrupts not a required property
Posted by Jonathan Cameron 1 year ago
On Fri, 13 Dec 2024 21:19:04 +0000
Lothar Rubusch <l.rubusch@gmail.com> wrote:

> Remove interrupts from the list of required properties. The ADXL345
> does not need interrupts for basic accelerometer functionality. The
> sensor offers optional events which can be indicated on one of two
> interrupt lines.
It is harmless but if you are spinning again, remove the last sentence.
It isn't really anything to do with the reasoning behind this patch
(well covered by the first sentence).  If everyone is fine with this
version I might just drop it whilst applying.

Jonathan

> 
> Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
> ---
>  Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> index 280ed479e..bc46ed00f 100644
> --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> @@ -40,7 +40,6 @@ properties:
>  required:
>    - compatible
>    - reg
> -  - interrupts
>  
>  allOf:
>    - $ref: /schemas/spi/spi-peripheral-props.yaml#