[PATCH 8/8] MAINTAINERS: Add Vincenzo Frascino as Arm Morello Maintainer

Vincenzo Frascino posted 8 patches 1 year, 1 month ago
There is a newer version of this series
[PATCH 8/8] MAINTAINERS: Add Vincenzo Frascino as Arm Morello Maintainer
Posted by Vincenzo Frascino 1 year, 1 month ago
Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
---
 MAINTAINERS | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index e6e71b05710b..8199e5945fb2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3304,6 +3304,12 @@ F:	drivers/clocksource/timer-versatile.c
 X:	drivers/cpufreq/vexpress-spc-cpufreq.c
 X:	Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
 
+ARM MORELLO PLATFORM SUPPORT
+M:	Vincenzo Frascino <vincenzo.frascino@arm.com>
+L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
+S:	Maintained
+F:	arch/arm64/boot/dts/arm/morello*
+
 ARM/VFP SUPPORT
 M:	Russell King <linux@armlinux.org.uk>
 L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
-- 
2.43.0
Re: [PATCH 8/8] MAINTAINERS: Add Vincenzo Frascino as Arm Morello Maintainer
Posted by Krzysztof Kozlowski 1 year, 1 month ago
On 13/12/2024 17:32, Vincenzo Frascino wrote:
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> ---
>  MAINTAINERS | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e6e71b05710b..8199e5945fb2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3304,6 +3304,12 @@ F:	drivers/clocksource/timer-versatile.c
>  X:	drivers/cpufreq/vexpress-spc-cpufreq.c
>  X:	Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
>  
> +ARM MORELLO PLATFORM SUPPORT

Wrongly placed, M is not after V, I know people cannot keep order but
let's try. No need for new Boogaloo.

Plus look how all the titles are created and do not come with different
style.

> +M:	Vincenzo Frascino <vincenzo.frascino@arm.com>
> +L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)


So why you did not bother to Cc this list? You are supposed to develop
on mainline kernel and then run get_maintainers.pl or b4 prep, so how is
possible that your Cc list is so empty?



> +S:	Maintained
> +F:	arch/arm64/boot/dts/arm/morello*


Missing bindings.



Best regards,
Krzysztof
Re: [PATCH 8/8] MAINTAINERS: Add Vincenzo Frascino as Arm Morello Maintainer
Posted by Vincenzo Frascino 1 year, 1 month ago

On 14/12/2024 10:19, Krzysztof Kozlowski wrote:
> On 13/12/2024 17:32, Vincenzo Frascino wrote:
>> Cc: Sudeep Holla <sudeep.holla@arm.com>
>> Cc: Rob Herring <robh@kernel.org>
>> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
>> ---
>>  MAINTAINERS | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index e6e71b05710b..8199e5945fb2 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -3304,6 +3304,12 @@ F:	drivers/clocksource/timer-versatile.c
>>  X:	drivers/cpufreq/vexpress-spc-cpufreq.c
>>  X:	Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
>>  
>> +ARM MORELLO PLATFORM SUPPORT
> 
> Wrongly placed, M is not after V, I know people cannot keep order but
> let's try. No need for new Boogaloo.
> 
> Plus look how all the titles are created and do not come with different
> style.
> 

Not sure I understand what you mean here. Do you mean that I have to put Morello
in alphabetical order in the file? Or just above VEXPRESS?

For what concerns the title, the MAINTAINERS file contains several styles (...
PLATFORM, PLATFORM SUPPORT, etc). What's your preference?

>> +M:	Vincenzo Frascino <vincenzo.frascino@arm.com>
>> +L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> 
> 
> So why you did not bother to Cc this list? You are supposed to develop
> on mainline kernel and then run get_maintainers.pl or b4 prep, so how is
> possible that your Cc list is so empty?
> 
> 
> 
>> +S:	Maintained
>> +F:	arch/arm64/boot/dts/arm/morello*
> 
> 
> Missing bindings.
> 
> 

There are no bindings specific to morello. What should I add here?

> 
> Best regards,
> Krzysztof

-- 
Regards,
Vincenzo
Re: [PATCH 8/8] MAINTAINERS: Add Vincenzo Frascino as Arm Morello Maintainer
Posted by Krzysztof Kozlowski 1 year, 1 month ago
On 19/12/2024 18:45, Vincenzo Frascino wrote:
> 
> 
> On 14/12/2024 10:19, Krzysztof Kozlowski wrote:
>> On 13/12/2024 17:32, Vincenzo Frascino wrote:
>>> Cc: Sudeep Holla <sudeep.holla@arm.com>
>>> Cc: Rob Herring <robh@kernel.org>
>>> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
>>> ---
>>>  MAINTAINERS | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index e6e71b05710b..8199e5945fb2 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -3304,6 +3304,12 @@ F:	drivers/clocksource/timer-versatile.c
>>>  X:	drivers/cpufreq/vexpress-spc-cpufreq.c
>>>  X:	Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
>>>  
>>> +ARM MORELLO PLATFORM SUPPORT
>>
>> Wrongly placed, M is not after V, I know people cannot keep order but
>> let's try. No need for new Boogaloo.
>>
>> Plus look how all the titles are created and do not come with different
>> style.
>>
> 
> Not sure I understand what you mean here. Do you mean that I have to put Morello
> in alphabetical order in the file? Or just above VEXPRESS?

Entries in maintainers are ordered, keep the order.

> 
> For what concerns the title, the MAINTAINERS file contains several styles (...
> PLATFORM, PLATFORM SUPPORT, etc). What's your preference?

Look how other arm platforms are called, e.g. vexpress. Create the same
style.


>>
>>
>> Missing bindings.
>>
>>
> 
> There are no bindings specific to morello. What should I add here?
> 

Ah, indeed, you added these to Vexpress Juno bindings. I missed that.
It's fine then.

Best regards,
Krzysztof