1. Patchew
  2. linux
  3. [PATCH 0/8] arm64: dts: Add Arm Morello support
  4. View patch

[PATCH 2/8] dt-bindings: mailbox: arm,mhu: Add missing properties

Vincenzo Frascino posted 8 patches 1 year, 1 month ago
There is a newer version of this series
[PATCH 2/8] dt-bindings: mailbox: arm,mhu: Add missing properties
Posted by Vincenzo Frascino 1 year, 1 month ago 
Add support for "interrupt-names" and "mbox-name" optional properties.

Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
---
 Documentation/devicetree/bindings/mailbox/arm,mhu.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
index d9a4f4a02d7c..65a4f66a7273 100644
--- a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
+++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
@@ -63,6 +63,16 @@ properties:
       - description: high-priority non-secure
       - description: Secure
 
+  interrupt-names:
+    minItems: 2
+    items:
+      - const: mhu-lpri-rx
+      - const: mhu-hpri-rx
+      - const: mhu-si-rx
+
+  mbox-name:
+    maxItems: 1
+
   clocks:
     maxItems: 1
 
-- 
2.43.0
Re: [PATCH 2/8] dt-bindings: mailbox: arm,mhu: Add missing properties
Posted by Krzysztof Kozlowski 1 year, 1 month ago 
On 13/12/2024 17:32, Vincenzo Frascino wrote:
> Add support for "interrupt-names" and "mbox-name" optional properties.

Why?


I wonder why you are not cc-ing other maintainers, like only Rob is
acceptable by you?

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument, so you will
not CC people just because they made one commit years ago). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
</form letter>

> 
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> ---
>  Documentation/devicetree/bindings/mailbox/arm,mhu.yaml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> index d9a4f4a02d7c..65a4f66a7273 100644
> --- a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> @@ -63,6 +63,16 @@ properties:
>        - description: high-priority non-secure
>        - description: Secure
>  
> +  interrupt-names:
> +    minItems: 2
> +    items:
> +      - const: mhu-lpri-rx
> +      - const: mhu-hpri-rx
> +      - const: mhu-si-rx

No, drop.

> +
> +  mbox-name:
> +    maxItems: 1

No clue what's this, for sure there is no such property at all and
commit msg does not explain it.


Drop entire patch.

Best regards,
Krzysztof
Re: [PATCH 2/8] dt-bindings: mailbox: arm,mhu: Add missing properties
Posted by Vincenzo Frascino 1 year, 1 month ago 

On 14/12/2024 10:10, Krzysztof Kozlowski wrote:
> On 13/12/2024 17:32, Vincenzo Frascino wrote:
>> Add support for "interrupt-names" and "mbox-name" optional properties.
> 
> Why?
> 
> 
> I wonder why you are not cc-ing other maintainers, like only Rob is
> acceptable by you?
>

No it is not. And this is why it is not a good idea to post patches on Friday
night. My intention was to copy linux-arm-kernel but I copied mistakenly
linux-kernel instead. I do apologize. I will fix this in the next iteration.

> <form letter>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC (and consider --no-git-fallback argument, so you will
> not CC people just because they made one commit years ago). It might
> happen, that command when run on an older kernel, gives you outdated
> entries. Therefore please be sure you base your patches on recent Linux
> kernel.
> 
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.
> </form letter>
> 
>>
>> Cc: Sudeep Holla <sudeep.holla@arm.com>
>> Cc: Rob Herring <robh@kernel.org>
>> Cc: Viresh Kumar <viresh.kumar@linaro.org>
>> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
>> ---
>>  Documentation/devicetree/bindings/mailbox/arm,mhu.yaml | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
>> index d9a4f4a02d7c..65a4f66a7273 100644
>> --- a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
>> +++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
>> @@ -63,6 +63,16 @@ properties:
>>        - description: high-priority non-secure
>>        - description: Secure
>>  
>> +  interrupt-names:
>> +    minItems: 2
>> +    items:
>> +      - const: mhu-lpri-rx
>> +      - const: mhu-hpri-rx
>> +      - const: mhu-si-rx
> 
> No, drop.
> 
>> +
>> +  mbox-name:
>> +    maxItems: 1
> 
> No clue what's this, for sure there is no such property at all and
> commit msg does not explain it.
> 
> 
> Drop entire patch.
>

Fine.

> Best regards,
> Krzysztof

-- 
Regards,
Vincenzo
Re: [PATCH 2/8] dt-bindings: mailbox: arm,mhu: Add missing properties
Posted by Krzysztof Kozlowski 1 year, 1 month ago 
On 19/12/2024 16:13, Vincenzo Frascino wrote:
> 
> 
> On 14/12/2024 10:10, Krzysztof Kozlowski wrote:
>> On 13/12/2024 17:32, Vincenzo Frascino wrote:
>>> Add support for "interrupt-names" and "mbox-name" optional properties.
>>
>> Why?
>>
>>
>> I wonder why you are not cc-ing other maintainers, like only Rob is
>> acceptable by you?
>>
> 
> No it is not. And this is why it is not a good idea to post patches on Friday
> night. My intention was to copy linux-arm-kernel but I copied mistakenly
> linux-kernel instead. I do apologize. I will fix this in the next iteration.

It is not the problem here. Both lists should be. Just use tools instead
of selecting addresses.


Best regards,
Krzysztof
Re: [PATCH 2/8] dt-bindings: mailbox: arm,mhu: Add missing properties
Posted by Vincenzo Frascino 1 year, 1 month ago 
On 19/12/2024 15:26, Krzysztof Kozlowski wrote:
> On 19/12/2024 16:13, Vincenzo Frascino wrote:
>>
>>
>> On 14/12/2024 10:10, Krzysztof Kozlowski wrote:
>>> On 13/12/2024 17:32, Vincenzo Frascino wrote:
>>>> Add support for "interrupt-names" and "mbox-name" optional properties.
>>>
>>> Why?
>>>
>>>
>>> I wonder why you are not cc-ing other maintainers, like only Rob is
>>> acceptable by you?
>>>
>>
>> No it is not. And this is why it is not a good idea to post patches on Friday
>> night. My intention was to copy linux-arm-kernel but I copied mistakenly
>> linux-kernel instead. I do apologize. I will fix this in the next iteration.
> 
> It is not the problem here. Both lists should be. Just use tools instead
> of selecting addresses.
>

Will do.

> 
> Best regards,
> Krzysztof

-- 
Regards,
Vincenzo

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.