[PATCH] sched_ext: Use sizeof_field for key_len in dsq_hash_params

Liang Jie posted 1 patch 1 year ago
kernel/sched/ext.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] sched_ext: Use sizeof_field for key_len in dsq_hash_params
Posted by Liang Jie 1 year ago
From: Liang Jie <liangjie@lixiang.com>

Update the `dsq_hash_params` initialization to use `sizeof_field`
for the `key_len` field instead of a hardcoded value.

This improves code readability and ensures the key length dynamically
matches the size of the `id` field in the `scx_dispatch_q` structure.

Signed-off-by: Liang Jie <liangjie@lixiang.com>
---
 kernel/sched/ext.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c
index 7fff1d045477..4bd964fc7bbb 100644
--- a/kernel/sched/ext.c
+++ b/kernel/sched/ext.c
@@ -960,7 +960,7 @@ static DEFINE_PER_CPU(struct task_struct *, direct_dispatch_task);
 static struct scx_dispatch_q **global_dsqs;
 
 static const struct rhashtable_params dsq_hash_params = {
-	.key_len		= 8,
+	.key_len		= sizeof_field(struct scx_dispatch_q, id),
 	.key_offset		= offsetof(struct scx_dispatch_q, id),
 	.head_offset		= offsetof(struct scx_dispatch_q, hash_node),
 };
-- 
2.25.1
Re: [PATCH] sched_ext: Use sizeof_field for key_len in dsq_hash_params
Posted by Tejun Heo 1 year ago
On Fri, Dec 13, 2024 at 05:52:54PM +0800, Liang Jie wrote:
> From: Liang Jie <liangjie@lixiang.com>
> 
> Update the `dsq_hash_params` initialization to use `sizeof_field`
> for the `key_len` field instead of a hardcoded value.
> 
> This improves code readability and ensures the key length dynamically
> matches the size of the `id` field in the `scx_dispatch_q` structure.
> 
> Signed-off-by: Liang Jie <liangjie@lixiang.com>

Applied to sched_ext/for-6.14.

Thanks.

-- 
tejun