Replace misleading log "insufficient headroom (0)" with more clear
"unmodifiable headroom".

Signed-off-by: Alex Shumsky <alexthreed@gmail.com>
---

Changes in v2:
- don't remove log completely, but reword it

 drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
index da72fd2d541f..c3a57e30c855 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
@@ -327,8 +327,8 @@ static netdev_tx_t brcmf_netdev_start_xmit(struct sk_buff *skb,
 	if (skb_headroom(skb) < drvr->hdrlen || skb_header_cloned(skb)) {
 		head_delta = max_t(int, drvr->hdrlen - skb_headroom(skb), 0);
 
-		brcmf_dbg(INFO, "%s: insufficient headroom (%d)\n",
-			  brcmf_ifname(ifp), head_delta);
+		brcmf_dbg(INFO, "%s: %s headroom\n", brcmf_ifname(ifp),
+			  head_delta ? "insufficient" : "unmodifiable");
 		atomic_inc(&drvr->bus_if->stats.pktcowed);
 		ret = pskb_expand_head(skb, ALIGN(head_delta, NET_SKB_PAD), 0,
 				       GFP_ATOMIC);
-- 
2.34.1

Alex Shumsky <alexthreed@gmail.com> wrote:

> Replace misleading log "insufficient headroom (0)" with more clear
> "unmodifiable headroom".
> 
> Signed-off-by: Alex Shumsky <alexthreed@gmail.com>
> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>

Patch applied to wireless-next.git, thanks.

aeda9245c7ce wifi: brcmfmac: clarify unmodifiable headroom log message

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20241213081402.625003-1-alexthreed@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

On 12/13/2024 9:14 AM, Alex Shumsky wrote:
> Replace misleading log "insufficient headroom (0)" with more clear
> "unmodifiable headroom".

Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Alex Shumsky <alexthreed@gmail.com>
> ---
> 
> Changes in v2:
> - don't remove log completely, but reword it
> 
>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)