The bit index of the peripheral clock for mmc A is wrong
This was probably not a problem for mmc A as the peripheral is likely left
enabled by the bootloader.

No issues has been reported so far but it could be a problem, most likely
some form of conflict between the ethernet and mmc A clock, breaking
ethernet on init.

Use the value provided by the documentation for mmc A before this
becomes an actual problem.

Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 drivers/clk/meson/g12a.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c
index d3539fe9f7af5538201a78ce560f662ddb3935f2..20be7b037c07535bd2115f6e70404a95a7832756 100644
--- a/drivers/clk/meson/g12a.c
+++ b/drivers/clk/meson/g12a.c
@@ -4311,7 +4311,7 @@ static MESON_GATE(g12a_spicc_1,			HHI_GCLK_MPEG0,	14);
 static MESON_GATE(g12a_hiu_reg,			HHI_GCLK_MPEG0,	19);
 static MESON_GATE(g12a_mipi_dsi_phy,		HHI_GCLK_MPEG0,	20);
 static MESON_GATE(g12a_assist_misc,		HHI_GCLK_MPEG0,	23);
-static MESON_GATE(g12a_emmc_a,			HHI_GCLK_MPEG0,	4);
+static MESON_GATE(g12a_emmc_a,			HHI_GCLK_MPEG0,	24);
 static MESON_GATE(g12a_emmc_b,			HHI_GCLK_MPEG0,	25);
 static MESON_GATE(g12a_emmc_c,			HHI_GCLK_MPEG0,	26);
 static MESON_GATE(g12a_audio_codec,		HHI_GCLK_MPEG0,	28);

---
base-commit: 52fd1709e41d3a85b48bcfe2404a024ebaf30c3b
change-id: 20241213-amlogic-clk-g12a-mmca-fix-c9ebacf34d9c

Best regards,
-- 
Jerome

Applied to clk-meson (clk-meson-next), thanks!

[1/1] clk: amlogic: g12a: fix mmc A peripheral clock
      https://github.com/BayLibre/clk-meson/commit/799ce46951dc

Best regards,
--
Jerome

On 13/12/2024 11:03, Jerome Brunet wrote:
> The bit index of the peripheral clock for mmc A is wrong
> This was probably not a problem for mmc A as the peripheral is likely left
> enabled by the bootloader.
> 
> No issues has been reported so far but it could be a problem, most likely
> some form of conflict between the ethernet and mmc A clock, breaking
> ethernet on init.
> 
> Use the value provided by the documentation for mmc A before this
> becomes an actual problem.
> 
> Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
>   drivers/clk/meson/g12a.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c
> index d3539fe9f7af5538201a78ce560f662ddb3935f2..20be7b037c07535bd2115f6e70404a95a7832756 100644
> --- a/drivers/clk/meson/g12a.c
> +++ b/drivers/clk/meson/g12a.c
> @@ -4311,7 +4311,7 @@ static MESON_GATE(g12a_spicc_1,			HHI_GCLK_MPEG0,	14);
>   static MESON_GATE(g12a_hiu_reg,			HHI_GCLK_MPEG0,	19);
>   static MESON_GATE(g12a_mipi_dsi_phy,		HHI_GCLK_MPEG0,	20);
>   static MESON_GATE(g12a_assist_misc,		HHI_GCLK_MPEG0,	23);
> -static MESON_GATE(g12a_emmc_a,			HHI_GCLK_MPEG0,	4);
> +static MESON_GATE(g12a_emmc_a,			HHI_GCLK_MPEG0,	24);
>   static MESON_GATE(g12a_emmc_b,			HHI_GCLK_MPEG0,	25);
>   static MESON_GATE(g12a_emmc_c,			HHI_GCLK_MPEG0,	26);
>   static MESON_GATE(g12a_audio_codec,		HHI_GCLK_MPEG0,	28);
> 
> ---
> base-commit: 52fd1709e41d3a85b48bcfe2404a024ebaf30c3b
> change-id: 20241213-amlogic-clk-g12a-mmca-fix-c9ebacf34d9c
> 
> Best regards,

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>