arm64: dts: qcom: sc8280xp: Fix up remoteproc register space sizes

[PATCH] arm64: dts: qcom: sc8280xp: Fix up remoteproc register space sizes

Posted by Konrad Dybcio 5 months ago

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Make sure the remoteproc reg ranges reflect the entire register space
they refer to.

Since they're unused by the driver, there's no functional change.

Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
index ef06d1ac084d3205a149feff880f457822dca2b4..c97d1eeaf890f7ac2814297bff299c0bdd0ddd04 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
@@ -2743,7 +2743,7 @@ usb_2_qmpphy1: phy@88f1000 {
 
 		remoteproc_adsp: remoteproc@3000000 {
 			compatible = "qcom,sc8280xp-adsp-pas";
-			reg = <0 0x03000000 0 0x100>;
+			reg = <0 0x03000000 0 0x10000>;
 
 			interrupts-extended = <&intc GIC_SPI 162 IRQ_TYPE_EDGE_RISING>,
 					      <&smp2p_adsp_in 0 IRQ_TYPE_EDGE_RISING>,
@@ -5254,7 +5254,7 @@ cpufreq_hw: cpufreq@18591000 {
 
 		remoteproc_nsp0: remoteproc@1b300000 {
 			compatible = "qcom,sc8280xp-nsp0-pas";
-			reg = <0 0x1b300000 0 0x100>;
+			reg = <0 0x1b300000 0 0x10000>;
 
 			interrupts-extended = <&intc GIC_SPI 578 IRQ_TYPE_EDGE_RISING>,
 					      <&smp2p_nsp0_in 0 IRQ_TYPE_EDGE_RISING>,
@@ -5385,7 +5385,7 @@ compute-cb@14 {
 
 		remoteproc_nsp1: remoteproc@21300000 {
 			compatible = "qcom,sc8280xp-nsp1-pas";
-			reg = <0 0x21300000 0 0x100>;
+			reg = <0 0x21300000 0 0x10000>;
 
 			interrupts-extended = <&intc GIC_SPI 887 IRQ_TYPE_EDGE_RISING>,
 					      <&smp2p_nsp1_in 0 IRQ_TYPE_EDGE_RISING>,

---
base-commit: 3e42dc9229c5950e84b1ed705f94ed75ed208228
change-id: 20241212-topic-8280_rproc_reg-15c636427963

Best regards,
-- 
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Re: [PATCH] arm64: dts: qcom: sc8280xp: Fix up remoteproc register space sizes

Posted by Bjorn Andersson 4 months ago

On Thu, 12 Dec 2024 23:19:37 +0100, Konrad Dybcio wrote:
> Make sure the remoteproc reg ranges reflect the entire register space
> they refer to.
> 
> Since they're unused by the driver, there's no functional change.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: sc8280xp: Fix up remoteproc register space sizes
      commit: 7ec7e327286182c65d0b5b81dff498d620fe9e8c

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH] arm64: dts: qcom: sc8280xp: Fix up remoteproc register space sizes

Posted by Bryan O'Donoghue 5 months ago

On 12/12/2024 22:19, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> Make sure the remoteproc reg ranges reflect the entire register space
> they refer to.
> 
> Since they're unused by the driver, there's no functional change.
> 
> Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>   arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index ef06d1ac084d3205a149feff880f457822dca2b4..c97d1eeaf890f7ac2814297bff299c0bdd0ddd04 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -2743,7 +2743,7 @@ usb_2_qmpphy1: phy@88f1000 {
>   
>   		remoteproc_adsp: remoteproc@3000000 {
>   			compatible = "qcom,sc8280xp-adsp-pas";
> -			reg = <0 0x03000000 0 0x100>;
> +			reg = <0 0x03000000 0 0x10000>;
>   
>   			interrupts-extended = <&intc GIC_SPI 162 IRQ_TYPE_EDGE_RISING>,
>   					      <&smp2p_adsp_in 0 IRQ_TYPE_EDGE_RISING>,
> @@ -5254,7 +5254,7 @@ cpufreq_hw: cpufreq@18591000 {
>   
>   		remoteproc_nsp0: remoteproc@1b300000 {
>   			compatible = "qcom,sc8280xp-nsp0-pas";
> -			reg = <0 0x1b300000 0 0x100>;
> +			reg = <0 0x1b300000 0 0x10000>;
>   
>   			interrupts-extended = <&intc GIC_SPI 578 IRQ_TYPE_EDGE_RISING>,
>   					      <&smp2p_nsp0_in 0 IRQ_TYPE_EDGE_RISING>,
> @@ -5385,7 +5385,7 @@ compute-cb@14 {
>   
>   		remoteproc_nsp1: remoteproc@21300000 {
>   			compatible = "qcom,sc8280xp-nsp1-pas";
> -			reg = <0 0x21300000 0 0x100>;
> +			reg = <0 0x21300000 0 0x10000>;
>   
>   			interrupts-extended = <&intc GIC_SPI 887 IRQ_TYPE_EDGE_RISING>,
>   					      <&smp2p_nsp1_in 0 IRQ_TYPE_EDGE_RISING>,
> 
> ---
> base-commit: 3e42dc9229c5950e84b1ed705f94ed75ed208228
> change-id: 20241212-topic-8280_rproc_reg-15c636427963
> 
> Best regards,

These ranges check out.

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>