staging: gpib: Wrapped macro in parentheses to ensure the correct evaluation order

[PATCH] staging: gpib: Wrapped macro in parentheses to ensure the correct evaluation order

eisantosh95@gmail.com posted 1 patch 1 year ago

Download mbox

drivers/staging/gpib/gpio/gpib_bitbang.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

Expand all Fold all

[PATCH] staging: gpib: Wrapped macro in parentheses to ensure the correct evaluation order

Posted by eisantosh95@gmail.com 1 year ago

From: Santosh Mahto <eisantosh95@gmail.com>

ERROR found by checkpatch.pl script

Signed-off-by: Santosh Mahto <eisantosh95@gmail.com>
---
 drivers/staging/gpib/gpio/gpib_bitbang.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/gpib/gpio/gpib_bitbang.c b/drivers/staging/gpib/gpio/gpib_bitbang.c
index a2d562cbd65b..3aec39a6d6b5 100644
--- a/drivers/staging/gpib/gpio/gpib_bitbang.c
+++ b/drivers/staging/gpib/gpio/gpib_bitbang.c
@@ -44,10 +44,10 @@
 			pr_info("%s:%s - " frm, NAME, __func__, ## __VA_ARGS__); } \
 	while (0)
 
-#define LINVAL gpiod_get_value(DAV),		\
-		gpiod_get_value(NRFD),		\
-		gpiod_get_value(NDAC),		\
-		gpiod_get_value(SRQ)
+#define LINVAL (gpiod_get_value(DAV),       \
+		gpiod_get_value(NRFD),              \
+		gpiod_get_value(NDAC),              \
+		gpiod_get_value(SRQ))
 #define LINFMT "DAV: %d	 NRFD:%d  NDAC: %d SRQ: %d"
 
 #include "gpibP.h"
-- 
2.25.1

Re: [PATCH] staging: gpib: Wrapped macro in parentheses to ensure the correct evaluation order

Posted by Dan Carpenter 1 year ago

On Thu, Dec 12, 2024 at 12:52:04AM +0530, eisantosh95@gmail.com wrote:
> From: Santosh Mahto <eisantosh95@gmail.com>
> 
> ERROR found by checkpatch.pl script
> 
> Signed-off-by: Santosh Mahto <eisantosh95@gmail.com>
> ---

Checkpatch isn't always right.  Adding parentheses breaks the build.

regards,
dan carpenter