[PATCH] rust: Fix EXPORT_SYMBOL_RUST_GPL macro to follow guidelines

eisantosh95@gmail.com posted 1 patch 1 year ago
rust/exports.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] rust: Fix EXPORT_SYMBOL_RUST_GPL macro to follow guidelines
Posted by eisantosh95@gmail.com 1 year ago
From: Santosh Mahto <eisantosh95@gmail.com>

Warning found by checkpatch.pl script.

Signed-off-by: Santosh Mahto <eisantosh95@gmail.com>
---
 rust/exports.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/exports.c b/rust/exports.c
index 587f0e776aba..4b34734d77c8 100644
--- a/rust/exports.c
+++ b/rust/exports.c
@@ -13,7 +13,7 @@
 
 #include <linux/export.h>
 
-#define EXPORT_SYMBOL_RUST_GPL(sym) extern int sym; EXPORT_SYMBOL_GPL(sym)
+#define EXPORT_SYMBOL_RUST_GPL(sym) EXPORT_SYMBOL_GPL(sym)
 
 #include "exports_core_generated.h"
 #include "exports_helpers_generated.h"
-- 
2.25.1
Re: [PATCH] rust: Fix EXPORT_SYMBOL_RUST_GPL macro to follow guidelines
Posted by Miguel Ojeda 1 year ago
On Wed, Dec 11, 2024 at 7:16 PM <eisantosh95@gmail.com> wrote:
>
> From: Santosh Mahto <eisantosh95@gmail.com>
>
> Warning found by checkpatch.pl script.

Thanks for the patch!

Which warning? I guess you mean:

    WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable

But this is not a normal use of `EXPORT_SYMBOL*()`, and anyway the
patch would break the build since the name is not declared otherwise.

Did you try to build the kernel after the patch with Rust enabled?

Cheers,
Miguel