ata: sata_gemini: Remove unused gemini_sata_reset_bridge()

[PATCH] ata: sata_gemini: Remove unused gemini_sata_reset_bridge()

Posted by linux@treblig.org 1 year ago

From: "Dr. David Alan Gilbert" <linux@treblig.org>

gemini_sata_reset_bridge() was added in 2017 by the initial
commit be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010")
but has never been used.

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/ata/sata_gemini.c | 12 ------------
 drivers/ata/sata_gemini.h |  1 -
 2 files changed, 13 deletions(-)

diff --git a/drivers/ata/sata_gemini.c b/drivers/ata/sata_gemini.c
index d040799bf9cb..821ca31effe7 100644
--- a/drivers/ata/sata_gemini.c
+++ b/drivers/ata/sata_gemini.c
@@ -224,18 +224,6 @@ void gemini_sata_stop_bridge(struct sata_gemini *sg, unsigned int bridge)
 }
 EXPORT_SYMBOL(gemini_sata_stop_bridge);
 
-int gemini_sata_reset_bridge(struct sata_gemini *sg,
-			     unsigned int bridge)
-{
-	if (bridge == 0)
-		reset_control_reset(sg->sata0_reset);
-	else
-		reset_control_reset(sg->sata1_reset);
-	msleep(10);
-	return gemini_sata_setup_bridge(sg, bridge);
-}
-EXPORT_SYMBOL(gemini_sata_reset_bridge);
-
 static int gemini_sata_bridge_init(struct sata_gemini *sg)
 {
 	struct device *dev = sg->dev;
diff --git a/drivers/ata/sata_gemini.h b/drivers/ata/sata_gemini.h
index 6f6e691d6007..b6e4a5c86e01 100644
--- a/drivers/ata/sata_gemini.h
+++ b/drivers/ata/sata_gemini.h
@@ -17,6 +17,5 @@ bool gemini_sata_bridge_enabled(struct sata_gemini *sg, bool is_ata1);
 enum gemini_muxmode gemini_sata_get_muxmode(struct sata_gemini *sg);
 int gemini_sata_start_bridge(struct sata_gemini *sg, unsigned int bridge);
 void gemini_sata_stop_bridge(struct sata_gemini *sg, unsigned int bridge);
-int gemini_sata_reset_bridge(struct sata_gemini *sg, unsigned int bridge);
 
 #endif
-- 
2.47.1

Re: [PATCH] ata: sata_gemini: Remove unused gemini_sata_reset_bridge()

Posted by Linus Walleij 1 year ago

On Wed, Dec 11, 2024 at 2:12 AM <linux@treblig.org> wrote:

> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> gemini_sata_reset_bridge() was added in 2017 by the initial
> commit be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010")
> but has never been used.
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Right it was never used because the corresponding reset in
the low-level PATA driver didn't work so I patched it out before
submitting.

But should you not also remove sata0_reset and
sata1_reset from struct sata_gemini and the code fetching
the two reset lines? And even #include <linux/reset.h>?

Yours,
Linus Walleij

Re: [PATCH] ata: sata_gemini: Remove unused gemini_sata_reset_bridge()

Posted by Dr. David Alan Gilbert 1 year ago

* Linus Walleij (linus.walleij@linaro.org) wrote:
> On Wed, Dec 11, 2024 at 2:12 AM <linux@treblig.org> wrote:
> 
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >
> > gemini_sata_reset_bridge() was added in 2017 by the initial
> > commit be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010")
> > but has never been used.
> >
> > Remove it.
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> 
> Right it was never used because the corresponding reset in
> the low-level PATA driver didn't work so I patched it out before
> submitting.

Ah right.

> But should you not also remove sata0_reset and
> sata1_reset from struct sata_gemini and the code fetching
> the two reset lines? And even #include <linux/reset.h>?

Oh I see, I was just looking for entirely unreferenced functions
but that takes a little more following to notice.

I'm happy to do that; are you OK with it as a follow up patch or
do you want a v2? (And can you test it, I don't have the hardware).

Dave

> Yours,
> Linus Walleij
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH] ata: sata_gemini: Remove unused gemini_sata_reset_bridge()

Posted by Damien Le Moal 1 year ago

On 12/12/24 06:49, Dr. David Alan Gilbert wrote:
> * Linus Walleij (linus.walleij@linaro.org) wrote:
>> On Wed, Dec 11, 2024 at 2:12 AM <linux@treblig.org> wrote:
>>
>>> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>>>
>>> gemini_sata_reset_bridge() was added in 2017 by the initial
>>> commit be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010")
>>> but has never been used.
>>>
>>> Remove it.
>>>
>>> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>>
>> Right it was never used because the corresponding reset in
>> the low-level PATA driver didn't work so I patched it out before
>> submitting.
> 
> Ah right.
> 
>> But should you not also remove sata0_reset and
>> sata1_reset from struct sata_gemini and the code fetching
>> the two reset lines? And even #include <linux/reset.h>?
> 
> Oh I see, I was just looking for entirely unreferenced functions
> but that takes a little more following to notice.
> 
> I'm happy to do that; are you OK with it as a follow up patch or
> do you want a v2? (And can you test it, I don't have the hardware).

I already applied your previous patch. But I can replace it. So either an
incremental patch or a v2 is fine with me. Thanks.

> 
> Dave
> 
>> Yours,
>> Linus Walleij


-- 
Damien Le Moal
Western Digital Research

Re: [PATCH] ata: sata_gemini: Remove unused gemini_sata_reset_bridge()

Posted by Dr. David Alan Gilbert 1 year ago

* Damien Le Moal (dlemoal@kernel.org) wrote:
> On 12/12/24 06:49, Dr. David Alan Gilbert wrote:
> > * Linus Walleij (linus.walleij@linaro.org) wrote:
> >> On Wed, Dec 11, 2024 at 2:12 AM <linux@treblig.org> wrote:
> >>
> >>> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >>>
> >>> gemini_sata_reset_bridge() was added in 2017 by the initial
> >>> commit be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010")
> >>> but has never been used.
> >>>
> >>> Remove it.
> >>>
> >>> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> >>
> >> Right it was never used because the corresponding reset in
> >> the low-level PATA driver didn't work so I patched it out before
> >> submitting.
> > 
> > Ah right.
> > 
> >> But should you not also remove sata0_reset and
> >> sata1_reset from struct sata_gemini and the code fetching
> >> the two reset lines? And even #include <linux/reset.h>?
> > 
> > Oh I see, I was just looking for entirely unreferenced functions
> > but that takes a little more following to notice.
> > 
> > I'm happy to do that; are you OK with it as a follow up patch or
> > do you want a v2? (And can you test it, I don't have the hardware).
> 
> I already applied your previous patch. But I can replace it. So either an
> incremental patch or a v2 is fine with me. Thanks.

Follow up patch posted as

Subject: [PATCH] ata: sata_gemini: Remove remaining reset glue
Date: Wed, 11 Dec 2024 23:52:50 +0000
Message-ID: <20241211235250.136985-1-linux@treblig.org>

Thanks,

Dave

> > 

> > Dave
> > 
> >> Yours,
> >> Linus Walleij
> 
> 
> -- 
> Damien Le Moal
> Western Digital Research
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH] ata: sata_gemini: Remove unused gemini_sata_reset_bridge()

Posted by Damien Le Moal 1 year ago

On 12/11/24 10:12 AM, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> gemini_sata_reset_bridge() was added in 2017 by the initial
> commit be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010")
> but has never been used.
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Applied to for-6.14. Thanks !

-- 
Damien Le Moal
Western Digital Research