[PATCH] riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions

E Shattow posted 1 patch 2 weeks, 2 days ago
arch/riscv/boot/dts/starfive/jh7110-pinfunc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions
Posted by E Shattow 2 weeks, 2 days ago
Fix a typo in StarFive JH7110 pin function definitions for GPOUT_SYS_SDIO1_DATA4

Fixes: e22f09e598d12 ("riscv: dts: starfive: Add StarFive JH7110 pin function definitions")
Signed-off-by: E Shattow <e@freeshell.de>
Acked-by: Hal Feng <hal.feng@starfivetech.com>
---
 arch/riscv/boot/dts/starfive/jh7110-pinfunc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h b/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h
index 256de17f5261..ae49c908e7fb 100644
--- a/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h
+++ b/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h
@@ -89,7 +89,7 @@
 #define GPOUT_SYS_SDIO1_DATA1			59
 #define GPOUT_SYS_SDIO1_DATA2			60
 #define GPOUT_SYS_SDIO1_DATA3			61
-#define GPOUT_SYS_SDIO1_DATA4			63
+#define GPOUT_SYS_SDIO1_DATA4			62
 #define GPOUT_SYS_SDIO1_DATA5			63
 #define GPOUT_SYS_SDIO1_DATA6			64
 #define GPOUT_SYS_SDIO1_DATA7			65
-- 
2.45.2
Re: [PATCH] riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions
Posted by Conor Dooley 1 week, 3 days ago
From: Conor Dooley <conor.dooley@microchip.com>

On Mon, 09 Dec 2024 20:19:56 -0800, E Shattow wrote:
> Fix a typo in StarFive JH7110 pin function definitions for GPOUT_SYS_SDIO1_DATA4
> 
> 

Applied to riscv-dt-for-next, thanks!

[1/1] riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions
      (no commit info)

Thanks,
Conor.
Re: [PATCH] riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions
Posted by Krzysztof Kozlowski 1 week, 6 days ago
On Mon, Dec 09, 2024 at 08:19:56PM -0800, E Shattow wrote:
> Fix a typo in StarFive JH7110 pin function definitions for GPOUT_SYS_SDIO1_DATA4
> 
> Fixes: e22f09e598d12 ("riscv: dts: starfive: Add StarFive JH7110 pin function definitions")
> Signed-off-by: E Shattow <e@freeshell.de>
> Acked-by: Hal Feng <hal.feng@starfivetech.com>
> ---

Why are you sending the same multiple times? Where is the changelog and
proper patch versioning?

Best regards,
Krzysztof
Re: [PATCH] riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions
Posted by E Shattow 1 week, 6 days ago
Hi Krzysztof,

On 12/13/24 01:37, Krzysztof Kozlowski wrote:
> On Mon, Dec 09, 2024 at 08:19:56PM -0800, E Shattow wrote:
>> Fix a typo in StarFive JH7110 pin function definitions for GPOUT_SYS_SDIO1_DATA4
>>
>> Fixes: e22f09e598d12 ("riscv: dts: starfive: Add StarFive JH7110 pin function definitions")
>> Signed-off-by: E Shattow <e@freeshell.de>
>> Acked-by: Hal Feng <hal.feng@starfivetech.com>
>> ---
> 
> Why are you sending the same multiple times? Where is the changelog and
> proper patch versioning?
> 
> Best regards,
> Krzysztof
> 

I did respond to Hal's comment that the patch is missing a commit title 
description and that I would re-send. How instead should the message be 
formatted so the patch commit title description is changed but the patch 
is not the same being sent multiple times?  And now, again, based on 
your comment that this is not a typo I will again change the commit 
description but I don't know how to do that without sending again as a 
duplicate.

Thank you for the review and for your patience with me when I am 
learning how to participate.

-E
Re: [PATCH] riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions
Posted by Conor Dooley 1 week, 3 days ago
On Fri, Dec 13, 2024 at 11:58:29AM -0800, E Shattow wrote:
> Hi Krzysztof,
> 
> On 12/13/24 01:37, Krzysztof Kozlowski wrote:
> > On Mon, Dec 09, 2024 at 08:19:56PM -0800, E Shattow wrote:
> > > Fix a typo in StarFive JH7110 pin function definitions for GPOUT_SYS_SDIO1_DATA4
> > > 
> > > Fixes: e22f09e598d12 ("riscv: dts: starfive: Add StarFive JH7110 pin function definitions")
> > > Signed-off-by: E Shattow <e@freeshell.de>
> > > Acked-by: Hal Feng <hal.feng@starfivetech.com>
> > > ---
> > 
> > Why are you sending the same multiple times? Where is the changelog and
> > proper patch versioning?
> > 
> > Best regards,
> > Krzysztof
> > 
> 
> I did respond to Hal's comment that the patch is missing a commit title
> description and that I would re-send. How instead should the message be
> formatted so the patch commit title description is changed but the patch is
> not the same being sent multiple times?  And now, again, based on your
> comment that this is not a typo I will again change the commit description
> but I don't know how to do that without sending again as a duplicate.
> 
> Thank you for the review and for your patience with me when I am learning
> how to participate.

FWIW, this should be v2. Don't resend for that.