riscv: dts: starfive: jh7110-common: Use named definition for mmc1 card detect

[PATCH] riscv: dts: starfive: jh7110-common: Use named definition for mmc1 card detect

Posted by E Shattow 2 weeks, 2 days ago

Use named definition for mmc1 card detect GPIO instead of numeric literal.

Fixes: ac9a37e2d6b63 ("riscv: dts: starfive: introduce a common board dtsi for jh7110 based boards")
Signed-off-by: E Shattow <e@freeshell.de>
---
 arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
index 48fb5091b817..12a90d38ab31 100644
--- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
+++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
@@ -281,7 +281,7 @@ &mmc1 {
 	bus-width = <4>;
 	no-sdio;
 	no-mmc;
-	cd-gpios = <&sysgpio 41 GPIO_ACTIVE_LOW>;
+	cd-gpios = <&sysgpio GPI_SYS_SDIO1_CD GPIO_ACTIVE_LOW>;
 	disable-wp;
 	cap-sd-highspeed;
 	post-power-on-delay-ms = <200>;

base-commit: 708d55db3edbe2ccf88d94b5f2e2b404bc0ba37c
-- 
2.45.2

Re: [PATCH] riscv: dts: starfive: jh7110-common: Use named definition for mmc1 card detect

Posted by Conor Dooley 1 week, 3 days ago

From: Conor Dooley <conor.dooley@microchip.com>

On Mon, 09 Dec 2024 20:06:46 -0800, E Shattow wrote:
> Use named definition for mmc1 card detect GPIO instead of numeric literal.
> 
> 

Applied to riscv-dt-for-next, thanks!

[1/1] riscv: dts: starfive: jh7110-common: Use named definition for mmc1 card detect
      https://git.kernel.org/conor/c/c96f15d79172

Thanks,
Conor.

Re: [PATCH] riscv: dts: starfive: jh7110-common: Use named definition for mmc1 card detect

Posted by Conor Dooley 1 week, 3 days ago

On Mon, Dec 09, 2024 at 08:06:46PM -0800, E Shattow wrote:
> Use named definition for mmc1 card detect GPIO instead of numeric literal.
> 
> Fixes: ac9a37e2d6b63 ("riscv: dts: starfive: introduce a common board dtsi for jh7110 based boards")

I don't think this is a fix. Don't resend for that, I'll remove the tag.

> Signed-off-by: E Shattow <e@freeshell.de>
> ---
>  arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> index 48fb5091b817..12a90d38ab31 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> @@ -281,7 +281,7 @@ &mmc1 {
>  	bus-width = <4>;
>  	no-sdio;
>  	no-mmc;
> -	cd-gpios = <&sysgpio 41 GPIO_ACTIVE_LOW>;
> +	cd-gpios = <&sysgpio GPI_SYS_SDIO1_CD GPIO_ACTIVE_LOW>;
>  	disable-wp;
>  	cap-sd-highspeed;
>  	post-power-on-delay-ms = <200>;
> 
> base-commit: 708d55db3edbe2ccf88d94b5f2e2b404bc0ba37c
> -- 
> 2.45.2
>