[PATCH 0/3] sunrpc: Deadcoding

linux@treblig.org posted 3 patches 1 year ago
include/linux/sunrpc/gss_asn1.h         |  81 ---------
include/linux/sunrpc/gss_krb5.h         |   1 -
include/linux/sunrpc/xprtmultipath.h    |   1 -
net/sunrpc/auth_gss/Makefile            |   2 +-
net/sunrpc/auth_gss/gss_generic_token.c | 231 ------------------------
net/sunrpc/auth_gss/gss_krb5_crypto.c   |  55 ------
net/sunrpc/auth_gss/gss_krb5_internal.h |   7 -
net/sunrpc/auth_gss/gss_mech_switch.c   |   1 -
net/sunrpc/xprtmultipath.c              |  17 --
9 files changed, 1 insertion(+), 395 deletions(-)
delete mode 100644 include/linux/sunrpc/gss_asn1.h
delete mode 100644 net/sunrpc/auth_gss/gss_generic_token.c
[PATCH 0/3] sunrpc: Deadcoding
Posted by linux@treblig.org 1 year ago
From: "Dr. David Alan Gilbert" <linux@treblig.org>

Hi,
  This is a bunch of deadcoding around the sunrpc code.
This all removes whole functions/definitions/files
rather than changing any actual codepaths.

Dave

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Dr. David Alan Gilbert (3):
  sunrpc: Remove unused xprt_iter_get_xprt
  sunrpc: Remove gss_generic_token deadcode
  sunrpc: Remove gss_{de,en}crypt_xdr_buf deadcode

 include/linux/sunrpc/gss_asn1.h         |  81 ---------
 include/linux/sunrpc/gss_krb5.h         |   1 -
 include/linux/sunrpc/xprtmultipath.h    |   1 -
 net/sunrpc/auth_gss/Makefile            |   2 +-
 net/sunrpc/auth_gss/gss_generic_token.c | 231 ------------------------
 net/sunrpc/auth_gss/gss_krb5_crypto.c   |  55 ------
 net/sunrpc/auth_gss/gss_krb5_internal.h |   7 -
 net/sunrpc/auth_gss/gss_mech_switch.c   |   1 -
 net/sunrpc/xprtmultipath.c              |  17 --
 9 files changed, 1 insertion(+), 395 deletions(-)
 delete mode 100644 include/linux/sunrpc/gss_asn1.h
 delete mode 100644 net/sunrpc/auth_gss/gss_generic_token.c

-- 
2.47.1
Re: [PATCH 0/3] sunrpc: Deadcoding
Posted by cel@kernel.org 11 months, 1 week ago
From: Chuck Lever <chuck.lever@oracle.com>

On Tue, 10 Dec 2024 01:02:22 +0000, linux@treblig.org wrote:
>   This is a bunch of deadcoding around the sunrpc code.
> This all removes whole functions/definitions/files
> rather than changing any actual codepaths.
> 
> Dave
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> 
> [...]

Applied to nfsd-testing, thanks!

[1/3] sunrpc: Remove unused xprt_iter_get_xprt
      commit: 8adbba46957fb64315205ec7f2cacc5a1a37e878
[2/3] sunrpc: Remove gss_generic_token deadcode
      commit: 678651b2327102b4e45ad5e830f232c7da177762
[3/3] sunrpc: Remove gss_{de,en}crypt_xdr_buf deadcode
      commit: 515f416ca1c064c77100f2944a8c61add0e8dd7b

--
Chuck Lever
Re: [PATCH 0/3] sunrpc: Deadcoding
Posted by Jeff Layton 1 year ago
On Tue, 2024-12-10 at 01:02 +0000, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> Hi,
>   This is a bunch of deadcoding around the sunrpc code.
> This all removes whole functions/definitions/files
> rather than changing any actual codepaths.
> 
> Dave
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> 
> Dr. David Alan Gilbert (3):
>   sunrpc: Remove unused xprt_iter_get_xprt
>   sunrpc: Remove gss_generic_token deadcode
>   sunrpc: Remove gss_{de,en}crypt_xdr_buf deadcode
> 
>  include/linux/sunrpc/gss_asn1.h         |  81 ---------
>  include/linux/sunrpc/gss_krb5.h         |   1 -
>  include/linux/sunrpc/xprtmultipath.h    |   1 -
>  net/sunrpc/auth_gss/Makefile            |   2 +-
>  net/sunrpc/auth_gss/gss_generic_token.c | 231 ------------------------
>  net/sunrpc/auth_gss/gss_krb5_crypto.c   |  55 ------
>  net/sunrpc/auth_gss/gss_krb5_internal.h |   7 -
>  net/sunrpc/auth_gss/gss_mech_switch.c   |   1 -
>  net/sunrpc/xprtmultipath.c              |  17 --
>  9 files changed, 1 insertion(+), 395 deletions(-)
>  delete mode 100644 include/linux/sunrpc/gss_asn1.h
>  delete mode 100644 net/sunrpc/auth_gss/gss_generic_token.c
> 

I love removing unused code. Assuming everything builds OK after this:

Reviewed-by: Jeff Layton <jlayton@kernel.org>