arm64: dts: qcom: x1e*: Fix USB QMP PHY supplies

[PATCH 0/8] arm64: dts: qcom: x1e*: Fix USB QMP PHY supplies

Posted by Stephan Gerhold 2 weeks, 2 days ago

On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
(i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
are actually powered by &vreg_l2j_1p2.

Since most X1E device trees just mirror the power supplies from the
x1e80100-crd device tree, this series fixes up all the X1E boards with
the same change.

Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
---
Stephan Gerhold (8):
      arm64: dts: qcom: x1e001de-devkit: Fix USB QMP PHY supplies
      arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Fix USB QMP PHY supplies
      arm64: dts: qcom: x1e80100-asus-vivobook-s15: Fix USB QMP PHY supplies
      arm64: dts: qcom: x1e80100-crd: Fix USB QMP PHY supplies
      arm64: dts: qcom: x1e80100-dell-xps13-9345: Fix USB QMP PHY supplies
      arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Fix USB QMP PHY supplies
      arm64: dts: qcom: x1e80100-microsoft-romulus: Fix USB QMP PHY supplies
      arm64: dts: qcom: x1e80100-qcp: Fix USB QMP PHY supplies

 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts               | 6 +++---
 arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 4 ++--
 arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts    | 4 ++--
 arch/arm64/boot/dts/qcom/x1e80100-crd.dts                  | 6 +++---
 arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts      | 4 ++--
 arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts   | 6 +++---
 arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi   | 4 ++--
 arch/arm64/boot/dts/qcom/x1e80100-qcp.dts                  | 6 +++---
 8 files changed, 20 insertions(+), 20 deletions(-)
---
base-commit: f2b086fc9f039773445d2606dc65dc091ec1830f
change-id: 20241115-x1e80100-usb-qmp-supply-fix-5cc5e39a7d02

Best regards,
-- 
Stephan Gerhold <stephan.gerhold@linaro.org>

Re: [PATCH 0/8] arm64: dts: qcom: x1e*: Fix USB QMP PHY supplies

Posted by Johan Hovold 2 weeks, 2 days ago

On Tue, Dec 10, 2024 at 10:07:31AM +0100, Stephan Gerhold wrote:
> On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
> (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
> are actually powered by &vreg_l2j_1p2.
> 
> Since most X1E device trees just mirror the power supplies from the
> x1e80100-crd device tree, this series fixes up all the X1E boards with
> the same change.

Nice find! I've confirmed that this matches both the CRD and T14s
schematics.

> Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>

> Stephan Gerhold (8):
>       arm64: dts: qcom: x1e001de-devkit: Fix USB QMP PHY supplies
>       arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Fix USB QMP PHY supplies

nit: We've been using the shorter "x1e78100-t14s" prefix for this one so
far. This may apply to some of the others as well.

>       arm64: dts: qcom: x1e80100-asus-vivobook-s15: Fix USB QMP PHY supplies
>       arm64: dts: qcom: x1e80100-crd: Fix USB QMP PHY supplies
>       arm64: dts: qcom: x1e80100-dell-xps13-9345: Fix USB QMP PHY supplies
>       arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Fix USB QMP PHY supplies
>       arm64: dts: qcom: x1e80100-microsoft-romulus: Fix USB QMP PHY supplies
>       arm64: dts: qcom: x1e80100-qcp: Fix USB QMP PHY supplies

Reviewed-by: Johan Hovold <johan+linaro@kernel.org>

Johan

Re: [PATCH 0/8] arm64: dts: qcom: x1e*: Fix USB QMP PHY supplies

Posted by Marc Zyngier 2 weeks, 2 days ago

On Tue, 10 Dec 2024 13:18:20 +0000,
Johan Hovold <johan@kernel.org> wrote:
> 
> On Tue, Dec 10, 2024 at 10:07:31AM +0100, Stephan Gerhold wrote:
> > On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
> > (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
> > are actually powered by &vreg_l2j_1p2.
> > 
> > Since most X1E device trees just mirror the power supplies from the
> > x1e80100-crd device tree, this series fixes up all the X1E boards with
> > the same change.
> 
> Nice find! I've confirmed that this matches both the CRD and T14s
> schematics.

Can someone with access to the schematics confirm that the devkit
indeed has the same supplies?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

Re: [PATCH 0/8] arm64: dts: qcom: x1e*: Fix USB QMP PHY supplies

Posted by Johan Hovold 2 weeks, 2 days ago

On Tue, Dec 10, 2024 at 01:27:26PM +0000, Marc Zyngier wrote:
> On Tue, 10 Dec 2024 13:18:20 +0000,
> Johan Hovold <johan@kernel.org> wrote:
> > 
> > On Tue, Dec 10, 2024 at 10:07:31AM +0100, Stephan Gerhold wrote:
> > > On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
> > > (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
> > > are actually powered by &vreg_l2j_1p2.
> > > 
> > > Since most X1E device trees just mirror the power supplies from the
> > > x1e80100-crd device tree, this series fixes up all the X1E boards with
> > > the same change.
> > 
> > Nice find! I've confirmed that this matches both the CRD and T14s
> > schematics.
> 
> Can someone with access to the schematics confirm that the devkit
> indeed has the same supplies?

Sibi, can you confirm our assumption that these definitions were copied
from the CRD devicetree and need to be fixed like this also for the
devkit?

Johan

Re: [PATCH 0/8] arm64: dts: qcom: x1e*: Fix USB QMP PHY supplies

Posted by Konrad Dybcio 2 weeks ago

On 10.12.2024 4:38 PM, Johan Hovold wrote:
> On Tue, Dec 10, 2024 at 01:27:26PM +0000, Marc Zyngier wrote:
>> On Tue, 10 Dec 2024 13:18:20 +0000,
>> Johan Hovold <johan@kernel.org> wrote:
>>>
>>> On Tue, Dec 10, 2024 at 10:07:31AM +0100, Stephan Gerhold wrote:
>>>> On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
>>>> (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
>>>> are actually powered by &vreg_l2j_1p2.
>>>>
>>>> Since most X1E device trees just mirror the power supplies from the
>>>> x1e80100-crd device tree, this series fixes up all the X1E boards with
>>>> the same change.
>>>
>>> Nice find! I've confirmed that this matches both the CRD and T14s
>>> schematics.
>>
>> Can someone with access to the schematics confirm that the devkit
>> indeed has the same supplies?
> 
> Sibi, can you confirm our assumption that these definitions were copied
> from the CRD devicetree and need to be fixed like this also for the
> devkit?

I can confirm the fix applies to devkit too.

Konrad