Update the Intel vendor events to the latest.
Update the metrics to TMA 5.01.
Add Arrowlake support.
Add metrics for LNL and GNR.
Address IIO uncore issue spotted on EMR, GRR, GNR, SPR and SRF.

The perf json was generated using the script:
https://github.com/intel/perfmon/blob/main/scripts/create_perf_json.py
with the generated json being in:
https://github.com/intel/perfmon/tree/main/scripts/perf

Thanks to Perry Taylor <perry.taylor@intel.com>, Caleb Biggers
<caleb.biggers@intel.com>, Edward Baker <edward.baker@intel.com> and
Weilin Wang <weilin.wang@intel.com> for helping get this patch series
together.

Ian Rogers (22):
  perf vendor events: Update Alderlake events/metrics
  perf vendor events: Update AlderlakeN events/metrics
  perf vendor events: Add Arrowlake events/metrics
  perf vendor events: Update Broadwell events/metrics
  perf vendor events: Update BroadwellDE events/metrics
  perf vendor events: Update BroadwellX events/metrics
  perf vendor events: Update CascadelakeX events/metrics
  perf vendor events: Update EmeraldRapids events/metrics
  perf vendor events: Update GrandRidge events/metrics
  perf vendor events: Update/add Graniterapids events/metrics
  perf vendor events: Update Haswell events/metrics
  perf vendor events: Update HaswellX events/metrics
  perf vendor events: Update Icelake events/metrics
  perf vendor events: Update IcelakeX events/metrics
  perf vendor events: Update/add Lunarlake events/metrics
  perf vendor events: Update Meteorlake events/metrics
  perf vendor events: Update Rocketlake events/metrics
  perf vendor events: Update Sapphirerapids events/metrics
  perf vendor events: Update Sierraforest events/metrics
  perf vendor events: Update Skylake metrics
  perf vendor events: Update SkylakeX events/metrics
  perf vendor events: Update Tigerlake events/metrics

 .../arch/x86/alderlake/adl-metrics.json       | 3637 ++++++++++---
 .../pmu-events/arch/x86/alderlake/cache.json  |  292 +-
 .../arch/x86/alderlake/floating-point.json    |   19 +-
 .../arch/x86/alderlake/frontend.json          |   19 -
 .../pmu-events/arch/x86/alderlake/memory.json |   32 +-
 .../arch/x86/alderlake/metricgroups.json      |   10 +-
 .../pmu-events/arch/x86/alderlake/other.json  |   92 +-
 .../arch/x86/alderlake/pipeline.json          |  127 +-
 .../arch/x86/alderlake/virtual-memory.json    |   33 +
 .../arch/x86/alderlaken/adln-metrics.json     |   83 +-
 .../pmu-events/arch/x86/alderlaken/cache.json |  227 +-
 .../arch/x86/alderlaken/floating-point.json   |   17 +-
 .../arch/x86/alderlaken/memory.json           |   20 +
 .../pmu-events/arch/x86/alderlaken/other.json |   81 +-
 .../arch/x86/alderlaken/pipeline.json         |   97 +-
 .../arch/x86/alderlaken/virtual-memory.json   |   30 +
 .../arch/x86/arrowlake/arl-metrics.json       | 4597 ++++++++++++++++
 .../pmu-events/arch/x86/arrowlake/cache.json  | 1444 ++++++
 .../arch/x86/arrowlake/floating-point.json    |  532 ++
 .../arch/x86/arrowlake/frontend.json          |  609 +++
 .../pmu-events/arch/x86/arrowlake/memory.json |  387 ++
 .../arch/x86/arrowlake/metricgroups.json      |  150 +
 .../pmu-events/arch/x86/arrowlake/other.json  |  279 +
 .../arch/x86/arrowlake/pipeline.json          | 2298 ++++++++
 .../arch/x86/arrowlake/uncore-cache.json      |   20 +
 .../x86/arrowlake/uncore-interconnect.json    |   47 +
 .../arch/x86/arrowlake/uncore-memory.json     |  142 +
 .../arch/x86/arrowlake/uncore-other.json      |   10 +
 .../arch/x86/arrowlake/virtual-memory.json    |  522 ++
 .../arch/x86/broadwell/bdw-metrics.json       |  312 +-
 .../pmu-events/arch/x86/broadwell/cache.json  |   10 +-
 .../arch/x86/broadwell/frontend.json          |    4 +-
 .../pmu-events/arch/x86/broadwell/memory.json |    8 +-
 .../arch/x86/broadwell/metricgroups.json      |    5 +
 .../arch/x86/broadwell/pipeline.json          |   10 +-
 .../arch/x86/broadwellde/bdwde-metrics.json   |  256 +-
 .../arch/x86/broadwellde/cache.json           |   10 +-
 .../arch/x86/broadwellde/frontend.json        |    4 +-
 .../arch/x86/broadwellde/memory.json          |    6 +-
 .../arch/x86/broadwellde/metricgroups.json    |    5 +
 .../arch/x86/broadwellde/pipeline.json        |   10 +-
 .../arch/x86/broadwellde/uncore-cache.json    |   28 +-
 .../x86/broadwellde/uncore-interconnect.json  |   16 +-
 .../arch/x86/broadwellx/bdx-metrics.json      |  344 +-
 .../pmu-events/arch/x86/broadwellx/cache.json |   10 +-
 .../arch/x86/broadwellx/frontend.json         |    4 +-
 .../arch/x86/broadwellx/memory.json           |    6 +-
 .../arch/x86/broadwellx/metricgroups.json     |    5 +
 .../arch/x86/broadwellx/pipeline.json         |   10 +-
 .../arch/x86/broadwellx/uncore-cache.json     |   28 +-
 .../x86/broadwellx/uncore-interconnect.json   |   36 +-
 .../arch/x86/broadwellx/uncore-memory.json    |    1 +
 .../arch/x86/cascadelakex/clx-metrics.json    |  767 +--
 .../arch/x86/cascadelakex/metricgroups.json   |    9 +-
 .../arch/x86/cascadelakex/uncore-cache.json   |   60 +-
 .../x86/cascadelakex/uncore-interconnect.json |   11 -
 .../arch/x86/emeraldrapids/cache.json         |   28 +-
 .../arch/x86/emeraldrapids/emr-metrics.json   | 1036 ++--
 .../arch/x86/emeraldrapids/frontend.json      |   19 -
 .../arch/x86/emeraldrapids/memory.json        |   15 +-
 .../arch/x86/emeraldrapids/metricgroups.json  |   10 +-
 .../arch/x86/emeraldrapids/pipeline.json      |   23 -
 .../arch/x86/emeraldrapids/uncore-io.json     |  218 +-
 .../arch/x86/grandridge/grr-metrics.json      |  284 +-
 .../arch/x86/grandridge/pipeline.json         |    3 +-
 .../arch/x86/grandridge/uncore-cache.json     |    4 +-
 .../x86/grandridge/uncore-interconnect.json   |   60 +
 .../arch/x86/grandridge/uncore-io.json        |  214 +-
 .../arch/x86/grandridge/uncore-memory.json    |    2 +-
 .../arch/x86/graniterapids/cache.json         |  110 +-
 .../arch/x86/graniterapids/counter.json       |    2 +-
 .../arch/x86/graniterapids/frontend.json      |   24 +-
 .../arch/x86/graniterapids/gnr-metrics.json   | 2311 +++++++++
 .../arch/x86/graniterapids/memory.json        |  121 +-
 .../arch/x86/graniterapids/metricgroups.json  |  145 +
 .../arch/x86/graniterapids/other.json         |   99 +
 .../arch/x86/graniterapids/pipeline.json      |   40 +-
 .../arch/x86/graniterapids/uncore-cache.json  |   14 +-
 .../graniterapids/uncore-interconnect.json    |   87 +
 .../arch/x86/graniterapids/uncore-io.json     |  280 +-
 .../arch/x86/graniterapids/uncore-memory.json |  122 +-
 .../arch/x86/graniterapids/uncore-power.json  |   98 +
 .../arch/x86/haswell/hsw-metrics.json         |  260 +-
 .../pmu-events/arch/x86/haswell/memory.json   |    2 +-
 .../arch/x86/haswell/metricgroups.json        |    5 +
 .../arch/x86/haswellx/hsx-metrics.json        |  296 +-
 .../arch/x86/haswellx/metricgroups.json       |    5 +
 .../arch/x86/haswellx/uncore-cache.json       |   28 +-
 .../x86/haswellx/uncore-interconnect.json     |   38 +-
 .../pmu-events/arch/x86/icelake/cache.json    |   34 +-
 .../pmu-events/arch/x86/icelake/frontend.json |   17 -
 .../arch/x86/icelake/icl-metrics.json         |  849 +--
 .../pmu-events/arch/x86/icelake/memory.json   |   13 +-
 .../arch/x86/icelake/metricgroups.json        |   10 +-
 .../pmu-events/arch/x86/icelake/pipeline.json |   30 +-
 .../arch/x86/icelake/uncore-interconnect.json |   76 -
 .../arch/x86/icelake/uncore-other.json        |    2 +-
 .../arch/x86/icelake/virtual-memory.json      |   18 +
 .../pmu-events/arch/x86/icelakex/cache.json   |   41 +-
 .../arch/x86/icelakex/frontend.json           |   17 -
 .../arch/x86/icelakex/icx-metrics.json        |  852 +--
 .../pmu-events/arch/x86/icelakex/memory.json  |   13 +-
 .../arch/x86/icelakex/metricgroups.json       |   10 +-
 .../arch/x86/icelakex/pipeline.json           |   30 +-
 .../pmu-events/arch/x86/lunarlake/cache.json  | 1322 ++++-
 .../arch/x86/lunarlake/floating-point.json    |  484 ++
 .../arch/x86/lunarlake/frontend.json          |  654 ++-
 .../arch/x86/lunarlake/lnl-metrics.json       | 4611 +++++++++++++++++
 .../pmu-events/arch/x86/lunarlake/memory.json |  262 +-
 .../arch/x86/lunarlake/metricgroups.json      |  150 +
 .../pmu-events/arch/x86/lunarlake/other.json  |  496 +-
 .../arch/x86/lunarlake/pipeline.json          | 2104 +++++++-
 .../arch/x86/lunarlake/uncore-memory.json     |   18 +
 .../arch/x86/lunarlake/virtual-memory.json    |  428 ++
 tools/perf/pmu-events/arch/x86/mapfile.csv    |   41 +-
 .../pmu-events/arch/x86/meteorlake/cache.json |   20 +
 .../arch/x86/meteorlake/frontend.json         |    9 +
 .../arch/x86/meteorlake/metricgroups.json     |   10 +-
 .../arch/x86/meteorlake/mtl-metrics.json      | 3818 +++++++++++---
 .../pmu-events/arch/x86/meteorlake/other.json |   22 +
 .../arch/x86/meteorlake/pipeline.json         |   57 +-
 .../pmu-events/arch/x86/rocketlake/cache.json |   34 +-
 .../arch/x86/rocketlake/frontend.json         |   17 -
 .../arch/x86/rocketlake/memory.json           |   13 +-
 .../arch/x86/rocketlake/metricgroups.json     |   10 +-
 .../arch/x86/rocketlake/pipeline.json         |   30 +-
 .../arch/x86/rocketlake/rkl-metrics.json      |  849 +--
 .../x86/rocketlake/uncore-interconnect.json   |   10 -
 .../arch/x86/rocketlake/uncore-other.json     |    2 +-
 .../arch/x86/rocketlake/virtual-memory.json   |   18 +
 .../arch/x86/sapphirerapids/cache.json        |   30 +-
 .../arch/x86/sapphirerapids/frontend.json     |   19 -
 .../arch/x86/sapphirerapids/memory.json       |   15 +-
 .../arch/x86/sapphirerapids/metricgroups.json |   10 +-
 .../arch/x86/sapphirerapids/pipeline.json     |   23 -
 .../arch/x86/sapphirerapids/spr-metrics.json  |  968 ++--
 .../arch/x86/sapphirerapids/uncore-io.json    |  138 +-
 .../arch/x86/sierraforest/counter.json        |    2 +-
 .../arch/x86/sierraforest/other.json          |   20 +
 .../arch/x86/sierraforest/pipeline.json       |    3 +-
 .../arch/x86/sierraforest/srf-metrics.json    |  308 +-
 .../arch/x86/sierraforest/uncore-cache.json   |   28 +-
 .../x86/sierraforest/uncore-interconnect.json |   87 +
 .../arch/x86/sierraforest/uncore-io.json      |  280 +-
 .../arch/x86/sierraforest/uncore-memory.json  |  122 +-
 .../arch/x86/sierraforest/uncore-power.json   |   98 +
 .../arch/x86/skylake/metricgroups.json        |    9 +-
 .../arch/x86/skylake/skl-metrics.json         |  684 ++-
 .../arch/x86/skylakex/metricgroups.json       |    9 +-
 .../arch/x86/skylakex/skx-metrics.json        |  740 +--
 .../arch/x86/skylakex/uncore-cache.json       |   60 +-
 .../x86/skylakex/uncore-interconnect.json     |   11 -
 .../pmu-events/arch/x86/tigerlake/cache.json  |   45 +-
 .../arch/x86/tigerlake/frontend.json          |   17 -
 .../pmu-events/arch/x86/tigerlake/memory.json |   13 +-
 .../arch/x86/tigerlake/metricgroups.json      |   10 +-
 .../arch/x86/tigerlake/pipeline.json          |   30 +-
 .../arch/x86/tigerlake/tgl-metrics.json       |  745 +--
 .../x86/tigerlake/uncore-interconnect.json    |    4 +-
 .../arch/x86/tigerlake/uncore-other.json      |    2 +-
 .../arch/x86/tigerlake/virtual-memory.json    |   18 +
 161 files changed, 37876 insertions(+), 8004 deletions(-)
 create mode 100644 tools/perf/pmu-events/arch/x86/arrowlake/arl-metrics.json
 create mode 100644 tools/perf/pmu-events/arch/x86/arrowlake/cache.json
 create mode 100644 tools/perf/pmu-events/arch/x86/arrowlake/floating-point.json
 create mode 100644 tools/perf/pmu-events/arch/x86/arrowlake/frontend.json
 create mode 100644 tools/perf/pmu-events/arch/x86/arrowlake/memory.json
 create mode 100644 tools/perf/pmu-events/arch/x86/arrowlake/metricgroups.json
 create mode 100644 tools/perf/pmu-events/arch/x86/arrowlake/other.json
 create mode 100644 tools/perf/pmu-events/arch/x86/arrowlake/pipeline.json
 create mode 100644 tools/perf/pmu-events/arch/x86/arrowlake/uncore-cache.json
 create mode 100644 tools/perf/pmu-events/arch/x86/arrowlake/uncore-interconnect.json
 create mode 100644 tools/perf/pmu-events/arch/x86/arrowlake/uncore-memory.json
 create mode 100644 tools/perf/pmu-events/arch/x86/arrowlake/uncore-other.json
 create mode 100644 tools/perf/pmu-events/arch/x86/arrowlake/virtual-memory.json
 create mode 100644 tools/perf/pmu-events/arch/x86/graniterapids/gnr-metrics.json
 create mode 100644 tools/perf/pmu-events/arch/x86/graniterapids/metricgroups.json
 create mode 100644 tools/perf/pmu-events/arch/x86/lunarlake/floating-point.json
 create mode 100644 tools/perf/pmu-events/arch/x86/lunarlake/lnl-metrics.json
 create mode 100644 tools/perf/pmu-events/arch/x86/lunarlake/metricgroups.json
 create mode 100644 tools/perf/pmu-events/arch/x86/lunarlake/uncore-memory.json

-- 
2.47.1.545.g3c1d2e2a6a-goog

On Mon, Dec 9, 2024 at 2:28 PM Ian Rogers <irogers@google.com> wrote:
>
> Update the Intel vendor events to the latest.
> Update the metrics to TMA 5.01.
> Add Arrowlake support.
> Add metrics for LNL and GNR.
> Address IIO uncore issue spotted on EMR, GRR, GNR, SPR and SRF.
>
> The perf json was generated using the script:
> https://github.com/intel/perfmon/blob/main/scripts/create_perf_json.py
> with the generated json being in:
> https://github.com/intel/perfmon/tree/main/scripts/perf
>
> Thanks to Perry Taylor <perry.taylor@intel.com>, Caleb Biggers
> <caleb.biggers@intel.com>, Edward Baker <edward.baker@intel.com> and
> Weilin Wang <weilin.wang@intel.com> for helping get this patch series
> together.

I should have also said, this series requires:
https://lore.kernel.org/all/20241113165558.628856-1-irogers@google.com/

Thanks,
Ian

On Mon, Dec 09, 2024 at 04:44:27PM -0800, Ian Rogers wrote:
> On Mon, Dec 9, 2024 at 2:28 PM Ian Rogers <irogers@google.com> wrote:
> >
> > Update the Intel vendor events to the latest.
> > Update the metrics to TMA 5.01.
> > Add Arrowlake support.
> > Add metrics for LNL and GNR.
> > Address IIO uncore issue spotted on EMR, GRR, GNR, SPR and SRF.
> >
> > The perf json was generated using the script:
> > https://github.com/intel/perfmon/blob/main/scripts/create_perf_json.py
> > with the generated json being in:
> > https://github.com/intel/perfmon/tree/main/scripts/perf
> >
> > Thanks to Perry Taylor <perry.taylor@intel.com>, Caleb Biggers
> > <caleb.biggers@intel.com>, Edward Baker <edward.baker@intel.com> and
> > Weilin Wang <weilin.wang@intel.com> for helping get this patch series
> > together.
> 
> I should have also said, this series requires:
> https://lore.kernel.org/all/20241113165558.628856-1-irogers@google.com/

Applying that one now to perf-tools-next,

Kan, can I have your Acked-by or Reviewed-by?

Thanks,

- Arnaldo

On 2024-12-10 2:03 p.m., Arnaldo Carvalho de Melo wrote:
> On Mon, Dec 09, 2024 at 04:44:27PM -0800, Ian Rogers wrote:
>> On Mon, Dec 9, 2024 at 2:28 PM Ian Rogers <irogers@google.com> wrote:
>>>
>>> Update the Intel vendor events to the latest.
>>> Update the metrics to TMA 5.01.
>>> Add Arrowlake support.
>>> Add metrics for LNL and GNR.
>>> Address IIO uncore issue spotted on EMR, GRR, GNR, SPR and SRF.
>>>
>>> The perf json was generated using the script:
>>> https://github.com/intel/perfmon/blob/main/scripts/create_perf_json.py
>>> with the generated json being in:
>>> https://github.com/intel/perfmon/tree/main/scripts/perf
>>>
>>> Thanks to Perry Taylor <perry.taylor@intel.com>, Caleb Biggers
>>> <caleb.biggers@intel.com>, Edward Baker <edward.baker@intel.com> and
>>> Weilin Wang <weilin.wang@intel.com> for helping get this patch series
>>> together.
>>
>> I should have also said, this series requires:
>> https://lore.kernel.org/all/20241113165558.628856-1-irogers@google.com/
> 
> Applying that one now to perf-tools-next,
> 
> Kan, can I have your Acked-by or Reviewed-by?
> 

Thanks Ian for the series!

Sure.

Acked-by: Kan Liang <kan.liang@linux.intel.com>

Thanks,
Kan

On Wed, Dec 11, 2024 at 8:24 AM Liang, Kan <kan.liang@linux.intel.com> wrote:
>
>
>
> On 2024-12-10 2:03 p.m., Arnaldo Carvalho de Melo wrote:
> > On Mon, Dec 09, 2024 at 04:44:27PM -0800, Ian Rogers wrote:
> >> On Mon, Dec 9, 2024 at 2:28 PM Ian Rogers <irogers@google.com> wrote:
> >>>
> >>> Update the Intel vendor events to the latest.
> >>> Update the metrics to TMA 5.01.
> >>> Add Arrowlake support.
> >>> Add metrics for LNL and GNR.
> >>> Address IIO uncore issue spotted on EMR, GRR, GNR, SPR and SRF.
> >>>
> >>> The perf json was generated using the script:
> >>> https://github.com/intel/perfmon/blob/main/scripts/create_perf_json.py
> >>> with the generated json being in:
> >>> https://github.com/intel/perfmon/tree/main/scripts/perf
> >>>
> >>> Thanks to Perry Taylor <perry.taylor@intel.com>, Caleb Biggers
> >>> <caleb.biggers@intel.com>, Edward Baker <edward.baker@intel.com> and
> >>> Weilin Wang <weilin.wang@intel.com> for helping get this patch series
> >>> together.
> >>
> >> I should have also said, this series requires:
> >> https://lore.kernel.org/all/20241113165558.628856-1-irogers@google.com/
> >
> > Applying that one now to perf-tools-next,
> >
> > Kan, can I have your Acked-by or Reviewed-by?
> >
>
> Thanks Ian for the series!
>
> Sure.
>
> Acked-by: Kan Liang <kan.liang@linux.intel.com>

Happy new year and thanks Kan! Arnaldo, Namhyung please let me know if
there is anything more necessary for this series. I don't believe it
needs a rebase.

Thanks,
Ian

On Mon, Jan 06, 2025 at 09:16:56AM -0800, Ian Rogers wrote:
> On Wed, Dec 11, 2024 at 8:24 AM Liang, Kan <kan.liang@linux.intel.com> wrote:
> > On 2024-12-10 2:03 p.m., Arnaldo Carvalho de Melo wrote:
> > >> I should have also said, this series requires:
> > >> https://lore.kernel.org/all/20241113165558.628856-1-irogers@google.com/

Checking that this is in...

> > > Applying that one now to perf-tools-next,

> > > Kan, can I have your Acked-by or Reviewed-by?

> > Sure.

> > Acked-by: Kan Liang <kan.liang@linux.intel.com>
 
> Happy new year and thanks Kan! Arnaldo, Namhyung please let me know if
> there is anything more necessary for this series. I don't believe it
> needs a rebase.

So, the Co-authored-by: tag was used and it is not documented in
Documentation/process/submitting-patches.rst, I think the right tag her
is "Co-developed-by:", and there are some rules about its usage, from
that doc:

---------------------------------- 8< ------------------------------

Co-developed-by: states that the patch was co-created by multiple developers;
it is used to give attribution to co-authors (in addition to the author
attributed by the From: tag) when several people work on a single patch.  Since
Co-developed-by: denotes authorship, every Co-developed-by: must be immediately
followed by a Signed-off-by: of the associated co-author.  Standard sign-off
procedure applies, i.e. the ordering of Signed-off-by: tags should reflect the
chronological history of the patch insofar as possible, regardless of whether
the author is attributed via From: or Co-developed-by:.  Notably, the last
Signed-off-by: must always be that of the developer submitting the patch.

---------------------------------- 8< ------------------------------

I'm taking the liberty to make these changes locally, please Ack these
changes by replying to this message, ok?

- Arnaldo

On Tue, Jan 7, 2025 at 11:56 AM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> On Mon, Jan 06, 2025 at 09:16:56AM -0800, Ian Rogers wrote:
> > On Wed, Dec 11, 2024 at 8:24 AM Liang, Kan <kan.liang@linux.intel.com> wrote:
> > > On 2024-12-10 2:03 p.m., Arnaldo Carvalho de Melo wrote:
> > > >> I should have also said, this series requires:
> > > >> https://lore.kernel.org/all/20241113165558.628856-1-irogers@google.com/
>
> Checking that this is in...
>
> > > > Applying that one now to perf-tools-next,
>
> > > > Kan, can I have your Acked-by or Reviewed-by?
>
> > > Sure.
>
> > > Acked-by: Kan Liang <kan.liang@linux.intel.com>
>
> > Happy new year and thanks Kan! Arnaldo, Namhyung please let me know if
> > there is anything more necessary for this series. I don't believe it
> > needs a rebase.
>
> So, the Co-authored-by: tag was used and it is not documented in
> Documentation/process/submitting-patches.rst, I think the right tag her
> is "Co-developed-by:", and there are some rules about its usage, from
> that doc:
>
> ---------------------------------- 8< ------------------------------
>
> Co-developed-by: states that the patch was co-created by multiple developers;
> it is used to give attribution to co-authors (in addition to the author
> attributed by the From: tag) when several people work on a single patch.  Since
> Co-developed-by: denotes authorship, every Co-developed-by: must be immediately
> followed by a Signed-off-by: of the associated co-author.  Standard sign-off
> procedure applies, i.e. the ordering of Signed-off-by: tags should reflect the
> chronological history of the patch insofar as possible, regardless of whether
> the author is attributed via From: or Co-developed-by:.  Notably, the last
> Signed-off-by: must always be that of the developer submitting the patch.
>
> ---------------------------------- 8< ------------------------------
>
> I'm taking the liberty to make these changes locally, please Ack these
> changes by replying to this message, ok?

Thanks Arnaldo, this makes sense to me. Caleb is adding Signed-off-by
tags from you okay?

Ian