MANA: Fix few memory leaks in mana_gd_setup_irqs

[PATCH v2 0/2] MANA: Fix few memory leaks in mana_gd_setup_irqs

Posted by Maxim Levitsky 1 year, 1 month ago

Fix 2 minor memory leaks in the mana driver,
introduced by commit

8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")

Best regards,
	Maxim Levitsky

Maxim Levitsky (2):
  net: mana: Fix memory leak in mana_gd_setup_irqs
  net: mana: Fix irq_contexts memory leak in mana_gd_setup_irqs

 drivers/net/ethernet/microsoft/mana/gdma_main.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

-- 
2.26.3

Re: [PATCH v2 0/2] MANA: Fix few memory leaks in mana_gd_setup_irqs

Posted by Yury Norov 1 year, 1 month ago

On Mon, Dec 09, 2024 at 12:57:49PM -0500, Maxim Levitsky wrote:
> Fix 2 minor memory leaks in the mana driver,
> introduced by commit
> 
> 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")

Reviewed-by: Yury Norov <yury.norov@gmail.com>

> 
> Best regards,
> 	Maxim Levitsky
> 
> Maxim Levitsky (2):
>   net: mana: Fix memory leak in mana_gd_setup_irqs
>   net: mana: Fix irq_contexts memory leak in mana_gd_setup_irqs
> 
>  drivers/net/ethernet/microsoft/mana/gdma_main.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> -- 
> 2.26.3
>

Re: [PATCH v2 0/2] MANA: Fix few memory leaks in mana_gd_setup_irqs

Posted by Saurabh Singh Sengar 1 year, 1 month ago

On Mon, Dec 09, 2024 at 12:57:49PM -0500, Maxim Levitsky wrote:
> Fix 2 minor memory leaks in the mana driver,
> introduced by commit
> 
> 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
> 
> Best regards,
> 	Maxim Levitsky
> 
> Maxim Levitsky (2):
>   net: mana: Fix memory leak in mana_gd_setup_irqs
>   net: mana: Fix irq_contexts memory leak in mana_gd_setup_irqs
> 
>  drivers/net/ethernet/microsoft/mana/gdma_main.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> -- 
> 2.26.3
> 
> 

Thanks for fixing this, for the series
Reviewed-by: Saurabh Sengar <ssengar@linux.microsoft.com>

could have been a single patch, though

Re: [PATCH v2 0/2] MANA: Fix few memory leaks in mana_gd_setup_irqs

Posted by Michal Swiatkowski 1 year, 1 month ago

On Mon, Dec 09, 2024 at 12:57:49PM -0500, Maxim Levitsky wrote:
> Fix 2 minor memory leaks in the mana driver,
> introduced by commit
> 
> 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
> 
> Best regards,
> 	Maxim Levitsky
> 

For next time please add a changleog, like here for example [1].
It is helpfull for the reviewers.

[1] https://lore.kernel.org/netdev/20241204140821.1858263-1-saikrishnag@marvell.com/T/#m5fc2fa8b1d2bd1b47cf7ccacd4031d1aa1aa8c2c

Thanks

> Maxim Levitsky (2):
>   net: mana: Fix memory leak in mana_gd_setup_irqs
>   net: mana: Fix irq_contexts memory leak in mana_gd_setup_irqs
> 
>  drivers/net/ethernet/microsoft/mana/gdma_main.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> -- 
> 2.26.3
> 
>