Noticed that there is a useless return statement at the end of void
function ubifs_dump_leb().
Just removed it.

Signed-off-by: Pintu Kumar <quic_pintu@quicinc.com>

---
Changes in V2:
Change commit title as suggested by Zhihao Cheng.
V1: https://lore.kernel.org/all/e43da923-0184-d41e-a273-a02848f3b671@huawei.com/
---
 fs/ubifs/debug.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
index 5cc69beaa62e..987eb5b6782a 100644
--- a/fs/ubifs/debug.c
+++ b/fs/ubifs/debug.c
@@ -863,7 +863,6 @@ void ubifs_dump_leb(const struct ubifs_info *c, int lnum)
 
 out:
 	vfree(buf);
-	return;
 }
 
 void ubifs_dump_znode(const struct ubifs_info *c,
-- 
2.17.1

在 2024/12/10 0:21, Pintu Kumar 写道:
> Noticed that there is a useless return statement at the end of void
> function ubifs_dump_leb().
> Just removed it.
> 
> Signed-off-by: Pintu Kumar <quic_pintu@quicinc.com>
> 

Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
> ---
> Changes in V2:
> Change commit title as suggested by Zhihao Cheng.
> V1: https://lore.kernel.org/all/e43da923-0184-d41e-a273-a02848f3b671@huawei.com/
> ---
>   fs/ubifs/debug.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
> index 5cc69beaa62e..987eb5b6782a 100644
> --- a/fs/ubifs/debug.c
> +++ b/fs/ubifs/debug.c
> @@ -863,7 +863,6 @@ void ubifs_dump_leb(const struct ubifs_info *c, int lnum)
>   
>   out:
>   	vfree(buf);
> -	return;
>   }
>   
>   void ubifs_dump_znode(const struct ubifs_info *c,
> 

Hi,

On Tue, 10 Dec 2024 at 06:40, Zhihao Cheng <chengzhihao1@huawei.com> wrote:
>
> 在 2024/12/10 0:21, Pintu Kumar 写道:
> > Noticed that there is a useless return statement at the end of void
> > function ubifs_dump_leb().
> > Just removed it.
> >
> > Signed-off-by: Pintu Kumar <quic_pintu@quicinc.com>
> >
>
> Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>

Thank you so much for your review.
Just a reminder, I don't see these 2 patches getting picked.
Am I missing anything ?


Thanks,
Pintu