[PATCH net-next v1 06/11] net: usb: lan78xx: Fix return value handling in lan78xx_set_features

Oleksij Rempel posted 11 patches 1 year ago
There is a newer version of this series
[PATCH net-next v1 06/11] net: usb: lan78xx: Fix return value handling in lan78xx_set_features
Posted by Oleksij Rempel 1 year ago
Update `lan78xx_set_features` to correctly return the result of
`lan78xx_write_reg`. This ensures that errors during register writes
are propagated to the caller.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 drivers/net/usb/lan78xx.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index b6e6c090a072..2966f7e63617 100644
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c
@@ -2837,9 +2837,7 @@ static int lan78xx_set_features(struct net_device *netdev,
 
 	spin_unlock_irqrestore(&pdata->rfe_ctl_lock, flags);
 
-	lan78xx_write_reg(dev, RFE_CTL, pdata->rfe_ctl);
-
-	return 0;
+	return lan78xx_write_reg(dev, RFE_CTL, pdata->rfe_ctl);
 }
 
 static void lan78xx_deferred_vlan_write(struct work_struct *param)
-- 
2.39.5
Re: [PATCH net-next v1 06/11] net: usb: lan78xx: Fix return value handling in lan78xx_set_features
Posted by Andrew Lunn 1 year ago
On Mon, Dec 09, 2024 at 02:07:46PM +0100, Oleksij Rempel wrote:
> Update `lan78xx_set_features` to correctly return the result of
> `lan78xx_write_reg`. This ensures that errors during register writes
> are propagated to the caller.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew