[PATCH net-next v1 05/11] net: usb: lan78xx: Simplify lan78xx_update_reg

Oleksij Rempel posted 11 patches 1 year ago
There is a newer version of this series
[PATCH net-next v1 05/11] net: usb: lan78xx: Simplify lan78xx_update_reg
Posted by Oleksij Rempel 1 year ago
Simplify `lan78xx_update_reg` by directly returning the result of
`lan78xx_write_reg`. This eliminates unnecessary checks and improves
code readability.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 drivers/net/usb/lan78xx.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index 62445aced7c6..b6e6c090a072 100644
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c
@@ -674,11 +674,7 @@ static int lan78xx_update_reg(struct lan78xx_net *dev, u32 reg, u32 mask,
 	buf &= ~mask;
 	buf |= (mask & data);
 
-	ret = lan78xx_write_reg(dev, reg, buf);
-	if (ret < 0)
-		return ret;
-
-	return 0;
+	return lan78xx_write_reg(dev, reg, buf);
 }
 
 static int lan78xx_read_stats(struct lan78xx_net *dev,
-- 
2.39.5
Re: [PATCH net-next v1 05/11] net: usb: lan78xx: Simplify lan78xx_update_reg
Posted by Andrew Lunn 1 year ago
On Mon, Dec 09, 2024 at 02:07:45PM +0100, Oleksij Rempel wrote:
> Simplify `lan78xx_update_reg` by directly returning the result of
> `lan78xx_write_reg`. This eliminates unnecessary checks and improves
> code readability.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew