[v1] nios2: Use str_yes_no() helper in show_cpuinfo()

[RESEND PATCH] nios2: Use str_yes_no() helper in show_cpuinfo()

Posted by Thorsten Blum 1 year ago

Remove hard-coded strings by using the str_yes_no() helper function.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 arch/nios2/kernel/cpuinfo.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/nios2/kernel/cpuinfo.c b/arch/nios2/kernel/cpuinfo.c
index 338849c430a5..7b1e8f9128e9 100644
--- a/arch/nios2/kernel/cpuinfo.c
+++ b/arch/nios2/kernel/cpuinfo.c
@@ -143,11 +143,11 @@ static int show_cpuinfo(struct seq_file *m, void *v)
 		   " DIV:\t\t%s\n"
 		   " BMX:\t\t%s\n"
 		   " CDX:\t\t%s\n",
-		   cpuinfo.has_mul ? "yes" : "no",
-		   cpuinfo.has_mulx ? "yes" : "no",
-		   cpuinfo.has_div ? "yes" : "no",
-		   cpuinfo.has_bmx ? "yes" : "no",
-		   cpuinfo.has_cdx ? "yes" : "no");
+		   str_yes_no(cpuinfo.has_mul),
+		   str_yes_no(cpuinfo.has_mulx),
+		   str_yes_no(cpuinfo.has_div),
+		   str_yes_no(cpuinfo.has_bmx),
+		   str_yes_no(cpuinfo.has_cdx));
 
 	seq_printf(m,
 		   "Icache:\t\t%ukB, line length: %u\n",
-- 
2.47.1

Re: [RESEND PATCH] nios2: Use str_yes_no() helper in show_cpuinfo()

Posted by Dinh Nguyen 1 year ago

On 12/9/24 05:06, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_yes_no() helper function.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>   arch/nios2/kernel/cpuinfo.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/nios2/kernel/cpuinfo.c b/arch/nios2/kernel/cpuinfo.c
> index 338849c430a5..7b1e8f9128e9 100644
> --- a/arch/nios2/kernel/cpuinfo.c
> +++ b/arch/nios2/kernel/cpuinfo.c
> @@ -143,11 +143,11 @@ static int show_cpuinfo(struct seq_file *m, void *v)
>   		   " DIV:\t\t%s\n"
>   		   " BMX:\t\t%s\n"
>   		   " CDX:\t\t%s\n",
> -		   cpuinfo.has_mul ? "yes" : "no",
> -		   cpuinfo.has_mulx ? "yes" : "no",
> -		   cpuinfo.has_div ? "yes" : "no",
> -		   cpuinfo.has_bmx ? "yes" : "no",
> -		   cpuinfo.has_cdx ? "yes" : "no");
> +		   str_yes_no(cpuinfo.has_mul),
> +		   str_yes_no(cpuinfo.has_mulx),
> +		   str_yes_no(cpuinfo.has_div),
> +		   str_yes_no(cpuinfo.has_bmx),
> +		   str_yes_no(cpuinfo.has_cdx));
>   
>   	seq_printf(m,
>   		   "Icache:\t\t%ukB, line length: %u\n",

Applied!

Thanks,
Dinh