This patch series is to fix bugs in drivers/of/irq.c

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
Zijun Hu (8):
      of/irq: Fix wrong value of variable @len in of_irq_parse_imap_parent()
      of/irq: Correct element count for array @dummy_imask in API of_irq_parse_raw()
      of/irq: Fix device node refcount leakage in API of_irq_parse_raw()
      of/irq: Fix using uninitialized variable @addr_len in API of_irq_parse_one()
      of/irq: Fix device node refcount leakage in API of_irq_parse_one()
      of/irq: Fix device node refcount leakages in of_irq_count()
      of/irq: Fix device node refcount leakages in of_irq_init()
      of/irq: Fix device node refcount leakage in API irq_of_parse_and_map()

 drivers/of/irq.c | 30 +++++++++++++++++++++++++-----
 1 file changed, 25 insertions(+), 5 deletions(-)
---
base-commit: 16ef9c9de0c48b836c5996c6e9792cb4f658c8f1
change-id: 20241208-of_irq_fix-659514bc9aa3

Best regards,
-- 
Zijun Hu <quic_zijuhu@quicinc.com>

On Mon, Dec 09, 2024 at 09:24:58PM +0800, Zijun Hu wrote:
> This patch series is to fix bugs in drivers/of/irq.c
> 
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
> ---
> Zijun Hu (8):
>       of/irq: Fix wrong value of variable @len in of_irq_parse_imap_parent()
>       of/irq: Correct element count for array @dummy_imask in API of_irq_parse_raw()
>       of/irq: Fix device node refcount leakage in API of_irq_parse_raw()
>       of/irq: Fix using uninitialized variable @addr_len in API of_irq_parse_one()
>       of/irq: Fix device node refcount leakage in API of_irq_parse_one()
>       of/irq: Fix device node refcount leakages in of_irq_count()
>       of/irq: Fix device node refcount leakages in of_irq_init()
>       of/irq: Fix device node refcount leakage in API irq_of_parse_and_map()

How did you find these refcount issues? Can we get a unit test for 
these.

Rob

On 2024/12/10 05:15, Rob Herring wrote:
> On Mon, Dec 09, 2024 at 09:24:58PM +0800, Zijun Hu wrote:
>> This patch series is to fix bugs in drivers/of/irq.c
>>
>> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
>> ---
>> Zijun Hu (8):
>>       of/irq: Fix wrong value of variable @len in of_irq_parse_imap_parent()
>>       of/irq: Correct element count for array @dummy_imask in API of_irq_parse_raw()
>>       of/irq: Fix device node refcount leakage in API of_irq_parse_raw()
>>       of/irq: Fix using uninitialized variable @addr_len in API of_irq_parse_one()
>>       of/irq: Fix device node refcount leakage in API of_irq_parse_one()
>>       of/irq: Fix device node refcount leakages in of_irq_count()
>>       of/irq: Fix device node refcount leakages in of_irq_init()
>>       of/irq: Fix device node refcount leakage in API irq_of_parse_and_map()
> 
> How did you find these refcount issues? Can we get a unit test for 
> these.
>

find them by reading codes.
yes. let me write some necessary unit tests for them.

> Rob