drivers/reset/amlogic/reset-meson-aux.c | 85 +++------------------------------ include/soc/amlogic/reset-meson-aux.h | 23 --------- 2 files changed, 6 insertions(+), 102 deletions(-)
The current implementation of auxiliary reset controller, with the
registration helper in the same module as the driver code, does not
allow to properly decouple the registered auxiliary driver from
the registering one.
This patchset removes the registration helper from the auxiliary reset
driver and changes how regmap is passed, to simplify the interface a bit.
This patcheset depends on:
commit 5ae1a43486fb ("clk: amlogic: axg-audio: revert reset implementation")
The above removes the only user of the auxiliary reset controller, restoring
old implementation as a temporary solution, while it is reworked.
The commit has been applied to clock fixes [1] branch and will eventually
make its way to an rc release.
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/commit/?h=clk-fixes&id=5ae1a43486fb3febd5ce78da13eb354f16d049e0
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
Jerome Brunet (2):
reset: amlogic: aux: get regmap through parent device
reset: amlogic: aux: drop aux registration helper
drivers/reset/amlogic/reset-meson-aux.c | 85 +++------------------------------
include/soc/amlogic/reset-meson-aux.h | 23 ---------
2 files changed, 6 insertions(+), 102 deletions(-)
---
base-commit: 3d99f9231bedcf9acfb965a97645a8ecfa93a40d
change-id: 20241209-meson-rst-aux-rework-e26c716c6762
prerequisite-change-id: 20241127-clk-audio-fix-rst-missing-0b80628d934b:v2
prerequisite-patch-id: 8bf55ab8ba9db1abea5df2554864a2f4f9c72e77
Best regards,
--
Jerome
On Mon 09 Dec 2024 at 17:04, Jerome Brunet <jbrunet@baylibre.com> wrote:
> The current implementation of auxiliary reset controller, with the
> registration helper in the same module as the driver code, does not
> allow to properly decouple the registered auxiliary driver from
> the registering one.
>
> This patchset removes the registration helper from the auxiliary reset
> driver and changes how regmap is passed, to simplify the interface a bit.
>
> This patcheset depends on:
> commit 5ae1a43486fb ("clk: amlogic: axg-audio: revert reset implementation")
>
> The above removes the only user of the auxiliary reset controller, restoring
> old implementation as a temporary solution, while it is reworked.
>
> The commit has been applied to clock fixes [1] branch and will eventually
> make its way to an rc release.
>
> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/commit/?h=clk-fixes&id=5ae1a43486fb3febd5ce78da13eb354f16d049e0
Hi Philipp,
FYI, the dependency above has made it to v6.13-rc3
Cheers
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> Jerome Brunet (2):
> reset: amlogic: aux: get regmap through parent device
> reset: amlogic: aux: drop aux registration helper
>
> drivers/reset/amlogic/reset-meson-aux.c | 85 +++------------------------------
> include/soc/amlogic/reset-meson-aux.h | 23 ---------
> 2 files changed, 6 insertions(+), 102 deletions(-)
> ---
> base-commit: 3d99f9231bedcf9acfb965a97645a8ecfa93a40d
> change-id: 20241209-meson-rst-aux-rework-e26c716c6762
> prerequisite-change-id: 20241127-clk-audio-fix-rst-missing-0b80628d934b:v2
> prerequisite-patch-id: 8bf55ab8ba9db1abea5df2554864a2f4f9c72e77
>
> Best regards,
--
Jerome
On Mon, Dec 9, 2024, at 17:04, Jerome Brunet wrote: > The current implementation of auxiliary reset controller, with the > registration helper in the same module as the driver code, does not > allow to properly decouple the registered auxiliary driver from > the registering one. > > This patchset removes the registration helper from the auxiliary reset > driver and changes how regmap is passed, to simplify the interface a bit. > Looks good to me, Acked-by: Arnd Bergmann <arnd@arndb.de>
© 2016 - 2025 Red Hat, Inc.