The max_register = 128 setting in the regmap config is not valid.

The Intel Dollar Cove TI PMIC has an eeprom unlock register at address 0x88
and a number of EEPROM registers at 0xF?. Increase max_register to 0xff so
that these registers can be accessed.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
Changes in v2:
- Increase max_register to 0xff instead of dropping it so that
  all the registers are shown in debugfs
---
 drivers/mfd/intel_soc_pmic_chtdc_ti.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/intel_soc_pmic_chtdc_ti.c b/drivers/mfd/intel_soc_pmic_chtdc_ti.c
index 992855bfda3e..8582ae65a802 100644
--- a/drivers/mfd/intel_soc_pmic_chtdc_ti.c
+++ b/drivers/mfd/intel_soc_pmic_chtdc_ti.c
@@ -81,7 +81,7 @@ static struct mfd_cell chtdc_ti_dev[] = {
 static const struct regmap_config chtdc_ti_regmap_config = {
 	.reg_bits = 8,
 	.val_bits = 8,
-	.max_register = 128,
+	.max_register = 0xff,
 	.cache_type = REGCACHE_NONE,
 };
 
-- 
2.47.1

On Sun, 08 Dec 2024 16:00:27 +0100, Hans de Goede wrote:
> The max_register = 128 setting in the regmap config is not valid.
> 
> The Intel Dollar Cove TI PMIC has an eeprom unlock register at address 0x88
> and a number of EEPROM registers at 0xF?. Increase max_register to 0xff so
> that these registers can be accessed.
> 
> 
> [...]

Applied, thanks!

[1/1] mfd: intel_soc_pmic_chtdc_ti: Fix invalid regmap-config max_register value
      commit: 1e19ff6d7ae149d933d0a6fbf09f6977c516b198

--
Lee Jones [李琼斯]

On Sun, Dec 8, 2024 at 5:00 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> The max_register = 128 setting in the regmap config is not valid.
>
> The Intel Dollar Cove TI PMIC has an eeprom unlock register at address 0x88
> and a number of EEPROM registers at 0xF?. Increase max_register to 0xff so
> that these registers can be accessed.

Reviewed-by: Andy Shevchenko <andy@kernel.org>

-- 
With Best Regards,
Andy Shevchenko