Make a minor change to eliminate a static checker warning. The type
of chip->irq is unsigned int, so the correct format specifier should be
%u instead of %i.
Signed-off-by: liujing <liujing@cmss.chinamobile.com>
diff --git a/sound/pci/au88x0/au88x0.c b/sound/pci/au88x0/au88x0.c
index 62b10b0e07b1..e3b1d7116110 100644
--- a/sound/pci/au88x0/au88x0.c
+++ b/sound/pci/au88x0/au88x0.c
@@ -223,7 +223,7 @@ __snd_vortex_probe(struct pci_dev *pci, const struct pci_device_id *pci_id)
// Card details needed in snd_vortex_midi
strcpy(card->driver, CARD_NAME_SHORT);
sprintf(card->shortname, "Aureal Vortex %s", CARD_NAME_SHORT);
- sprintf(card->longname, "%s at 0x%lx irq %i",
+ sprintf(card->longname, "%s at 0x%lx irq %u",
card->shortname, chip->io, chip->irq);
// (4) Alloc components.
--
2.27.0
On Fri, 06 Dec 2024 03:05:43 +0100, liujing wrote: > > Make a minor change to eliminate a static checker warning. The type > of chip->irq is unsigned int, so the correct format specifier should be > %u instead of %i. > > Signed-off-by: liujing <liujing@cmss.chinamobile.com> In this particular case, it's better to correct snd_vortex.irq to be normal signed int. The validity check is with a negative value, as it's initialized with -1. thanks, Takashi > > diff --git a/sound/pci/au88x0/au88x0.c b/sound/pci/au88x0/au88x0.c > index 62b10b0e07b1..e3b1d7116110 100644 > --- a/sound/pci/au88x0/au88x0.c > +++ b/sound/pci/au88x0/au88x0.c > @@ -223,7 +223,7 @@ __snd_vortex_probe(struct pci_dev *pci, const struct pci_device_id *pci_id) > // Card details needed in snd_vortex_midi > strcpy(card->driver, CARD_NAME_SHORT); > sprintf(card->shortname, "Aureal Vortex %s", CARD_NAME_SHORT); > - sprintf(card->longname, "%s at 0x%lx irq %i", > + sprintf(card->longname, "%s at 0x%lx irq %u", > card->shortname, chip->io, chip->irq); > > // (4) Alloc components. > -- > 2.27.0 > > >
© 2016 - 2025 Red Hat, Inc.