[PATCH v3 5/5] MAINTAINERS: Add Rust Misc Sample to MISC entry

Lee Jones posted 5 patches 1 year ago
There is a newer version of this series
[PATCH v3 5/5] MAINTAINERS: Add Rust Misc Sample to MISC entry
Posted by Lee Jones 1 year ago
Signed-off-by: Lee Jones <lee@kernel.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 21f855fe468b..ea5f7c628235 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5328,6 +5328,7 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
 F:	drivers/char/
 F:	drivers/misc/
 F:	include/linux/miscdevice.h
+F:	samples/rust/rust_misc_device.rs
 X:	drivers/char/agp/
 X:	drivers/char/hw_random/
 X:	drivers/char/ipmi/
-- 
2.47.0.338.g60cca15819-goog
Re: [PATCH v3 5/5] MAINTAINERS: Add Rust Misc Sample to MISC entry
Posted by Greg KH 1 year ago
On Thu, Dec 05, 2024 at 04:25:22PM +0000, Lee Jones wrote:
> Signed-off-by: Lee Jones <lee@kernel.org>

You know I can't take changelog entries without any text :(

> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 21f855fe468b..ea5f7c628235 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5328,6 +5328,7 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
>  F:	drivers/char/
>  F:	drivers/misc/
>  F:	include/linux/miscdevice.h
> +F:	samples/rust/rust_misc_device.rs

Nice, you are signing me up to maintain it for 20+ years?

{sigh}

greg k-h
Re: [PATCH v3 5/5] MAINTAINERS: Add Rust Misc Sample to MISC entry
Posted by Lee Jones 1 year ago
On Fri, 06 Dec 2024, Greg KH wrote:

> On Thu, Dec 05, 2024 at 04:25:22PM +0000, Lee Jones wrote:
> > Signed-off-by: Lee Jones <lee@kernel.org>
> 
> You know I can't take changelog entries without any text :(

What more is there to say?  Okay, I'll work something out.

> > ---
> >  MAINTAINERS | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 21f855fe468b..ea5f7c628235 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -5328,6 +5328,7 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
> >  F:	drivers/char/
> >  F:	drivers/misc/
> >  F:	include/linux/miscdevice.h
> > +F:	samples/rust/rust_misc_device.rs
> 
> Nice, you are signing me up to maintain it for 20+ years?

It's fine if you don't want it.

So either I can create a new entry with Alice (with permission of
course) and I as maintainers or just leave it as the default catch-call
of samples/rust/ which is already covered by 'RUST'.

-- 
Lee Jones [李琼斯]
Re: [PATCH v3 5/5] MAINTAINERS: Add Rust Misc Sample to MISC entry
Posted by Greg KH 1 year ago
On Fri, Dec 06, 2024 at 07:07:15AM +0000, Lee Jones wrote:
> On Fri, 06 Dec 2024, Greg KH wrote:
> 
> > On Thu, Dec 05, 2024 at 04:25:22PM +0000, Lee Jones wrote:
> > > Signed-off-by: Lee Jones <lee@kernel.org>
> > 
> > You know I can't take changelog entries without any text :(
> 
> What more is there to say?  Okay, I'll work something out.
> 
> > > ---
> > >  MAINTAINERS | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 21f855fe468b..ea5f7c628235 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -5328,6 +5328,7 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
> > >  F:	drivers/char/
> > >  F:	drivers/misc/
> > >  F:	include/linux/miscdevice.h
> > > +F:	samples/rust/rust_misc_device.rs
> > 
> > Nice, you are signing me up to maintain it for 20+ years?
> 
> It's fine if you don't want it.
> 
> So either I can create a new entry with Alice (with permission of
> course) and I as maintainers or just leave it as the default catch-call
> of samples/rust/ which is already covered by 'RUST'.

A simple "hey, do you want to maintain this" would have at least been
appreciated.  I can maintain it, but to just assume so is, well...
Re: [PATCH v3 5/5] MAINTAINERS: Add Rust Misc Sample to MISC entry
Posted by Lee Jones 1 year ago
On Fri, 06 Dec 2024, Greg KH wrote:

> On Fri, Dec 06, 2024 at 07:07:15AM +0000, Lee Jones wrote:
> > On Fri, 06 Dec 2024, Greg KH wrote:
> > 
> > > On Thu, Dec 05, 2024 at 04:25:22PM +0000, Lee Jones wrote:
> > > > Signed-off-by: Lee Jones <lee@kernel.org>
> > > 
> > > You know I can't take changelog entries without any text :(
> > 
> > What more is there to say?  Okay, I'll work something out.
> > 
> > > > ---
> > > >  MAINTAINERS | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index 21f855fe468b..ea5f7c628235 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -5328,6 +5328,7 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
> > > >  F:	drivers/char/
> > > >  F:	drivers/misc/
> > > >  F:	include/linux/miscdevice.h
> > > > +F:	samples/rust/rust_misc_device.rs
> > > 
> > > Nice, you are signing me up to maintain it for 20+ years?
> > 
> > It's fine if you don't want it.
> > 
> > So either I can create a new entry with Alice (with permission of
> > course) and I as maintainers or just leave it as the default catch-call
> > of samples/rust/ which is already covered by 'RUST'.
> 
> A simple "hey, do you want to maintain this" would have at least been
> appreciated.

This is it - feel free to NACK. :)

> I can maintain it, but to just assume so is, well...

Sorry if it offended you.  That wasn't the intention.

-- 
Lee Jones [李琼斯]