[PATCH v3 2/5] Documentation: ioctl-number: Carve out some identifiers for use by sample drivers

Lee Jones posted 5 patches 1 year ago
There is a newer version of this series
[PATCH v3 2/5] Documentation: ioctl-number: Carve out some identifiers for use by sample drivers
Posted by Lee Jones 1 year ago
32 IDs should be plenty (at yet, not too greedy) since a lot of sample
drivers will use their own subsystem allocations.

Sample drivers predominately reside in <KERNEL_ROOT>/samples, but there
should be no issue with in-place example drivers using them.

Signed-off-by: Lee Jones <lee@kernel.org>
---
 Documentation/userspace-api/ioctl/ioctl-number.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst b/Documentation/userspace-api/ioctl/ioctl-number.rst
index 243f1f1b554a..dc4bc0cab69f 100644
--- a/Documentation/userspace-api/ioctl/ioctl-number.rst
+++ b/Documentation/userspace-api/ioctl/ioctl-number.rst
@@ -311,6 +311,7 @@ Code  Seq#    Include File                                           Comments
                                                                      <mailto:oe@port.de>
 'z'   10-4F  drivers/s390/crypto/zcrypt_api.h                        conflict!
 '|'   00-7F  linux/media.h
+'|'   80-9F  samples/                                                Any sample and example drivers
 0x80  00-1F  linux/fb.h
 0x81  00-1F  linux/vduse.h
 0x89  00-06  arch/x86/include/asm/sockios.h
-- 
2.47.0.338.g60cca15819-goog
Re: [PATCH v3 2/5] Documentation: ioctl-number: Carve out some identifiers for use by sample drivers
Posted by Greg KH 1 year ago
On Thu, Dec 05, 2024 at 04:25:19PM +0000, Lee Jones wrote:
> 32 IDs should be plenty (at yet, not too greedy) since a lot of sample
> drivers will use their own subsystem allocations.
> 
> Sample drivers predominately reside in <KERNEL_ROOT>/samples, but there
> should be no issue with in-place example drivers using them.
> 
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
>  Documentation/userspace-api/ioctl/ioctl-number.rst | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst b/Documentation/userspace-api/ioctl/ioctl-number.rst
> index 243f1f1b554a..dc4bc0cab69f 100644
> --- a/Documentation/userspace-api/ioctl/ioctl-number.rst
> +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst
> @@ -311,6 +311,7 @@ Code  Seq#    Include File                                           Comments
>                                                                       <mailto:oe@port.de>
>  'z'   10-4F  drivers/s390/crypto/zcrypt_api.h                        conflict!
>  '|'   00-7F  linux/media.h
> +'|'   80-9F  samples/                                                Any sample and example drivers

This is fine, but why does the sample driver use "R" as the key instead?

thanks,

greg k-h
Re: [PATCH v3 2/5] Documentation: ioctl-number: Carve out some identifiers for use by sample drivers
Posted by Lee Jones 1 year ago
On Fri, 06 Dec 2024, Greg KH wrote:

> On Thu, Dec 05, 2024 at 04:25:19PM +0000, Lee Jones wrote:
> > 32 IDs should be plenty (at yet, not too greedy) since a lot of sample
> > drivers will use their own subsystem allocations.
> > 
> > Sample drivers predominately reside in <KERNEL_ROOT>/samples, but there
> > should be no issue with in-place example drivers using them.
> > 
> > Signed-off-by: Lee Jones <lee@kernel.org>
> > ---
> >  Documentation/userspace-api/ioctl/ioctl-number.rst | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst b/Documentation/userspace-api/ioctl/ioctl-number.rst
> > index 243f1f1b554a..dc4bc0cab69f 100644
> > --- a/Documentation/userspace-api/ioctl/ioctl-number.rst
> > +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst
> > @@ -311,6 +311,7 @@ Code  Seq#    Include File                                           Comments
> >                                                                       <mailto:oe@port.de>
> >  'z'   10-4F  drivers/s390/crypto/zcrypt_api.h                        conflict!
> >  '|'   00-7F  linux/media.h
> > +'|'   80-9F  samples/                                                Any sample and example drivers
> 
> This is fine, but why does the sample driver use "R" as the key instead?

You're right, I need to change that (and the example user app) over
to use this new keyword as well.  Thanks for noticing.

-- 
Lee Jones [李琼斯]