On 2025/1/7 8:55, Bjorn Andersson wrote:
> On Thu, Dec 05, 2024 at 08:31:34PM -0800, Abhinav Kumar wrote:
>> Interface type of MST interfaces is currently INTF_NONE.
>> Fix this to INTF_DP.
>>
>
> Wouldn't it make sense to introduce this later in the series, once the
> implementation would actually handle this case? Or could/should we have
> left these INTF_DP from the start?
>
> Regards,
> Bjorn
>
Yes, it's better to place this patch at the end of the series, once the
platform is already capable of handling MST.
>> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
>> ---
>> drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_4_sa8775p.h | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_4_sa8775p.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_4_sa8775p.h
>> index 907b4d7ceb470b0391d2bbbab3ce520efa2b3263..2509e28e3d6b582cd837c6aea167b3f4ad877383 100644
>> --- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_4_sa8775p.h
>> +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_4_sa8775p.h
>> @@ -375,7 +375,7 @@ static const struct dpu_intf_cfg sa8775p_intf[] = {
>> .name = "intf_3", .id = INTF_3,
>> .base = 0x37000, .len = 0x280,
>> .features = INTF_SC7280_MASK,
>> - .type = INTF_NONE,
>> + .type = INTF_DP,
>> .controller_id = MSM_DP_CONTROLLER_0, /* pair with intf_0 for DP MST */
>> .prog_fetch_lines_worst_case = 24,
>> .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 30),
>> @@ -393,7 +393,7 @@ static const struct dpu_intf_cfg sa8775p_intf[] = {
>> .name = "intf_6", .id = INTF_6,
>> .base = 0x3A000, .len = 0x280,
>> .features = INTF_SC7280_MASK,
>> - .type = INTF_NONE,
>> + .type = INTF_DP,
>> .controller_id = MSM_DP_CONTROLLER_0, /* pair with intf_0 for DP MST */
>> .prog_fetch_lines_worst_case = 24,
>> .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 17),
>> @@ -402,7 +402,7 @@ static const struct dpu_intf_cfg sa8775p_intf[] = {
>> .name = "intf_7", .id = INTF_7,
>> .base = 0x3b000, .len = 0x280,
>> .features = INTF_SC7280_MASK,
>> - .type = INTF_NONE,
>> + .type = INTF_DP,
>> .controller_id = MSM_DP_CONTROLLER_0, /* pair with intf_0 for DP MST */
>> .prog_fetch_lines_worst_case = 24,
>> .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 18),
>> @@ -411,7 +411,7 @@ static const struct dpu_intf_cfg sa8775p_intf[] = {
>> .name = "intf_8", .id = INTF_8,
>> .base = 0x3c000, .len = 0x280,
>> .features = INTF_SC7280_MASK,
>> - .type = INTF_NONE,
>> + .type = INTF_DP,
>> .controller_id = MSM_DP_CONTROLLER_1, /* pair with intf_4 for DP MST */
>> .prog_fetch_lines_worst_case = 24,
>> .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 12),
>>
>> --
>> 2.34.1
>>