[PATCH net-next v1 04/21] net: usb: lan78xx: Improve error reporting with %pe specifier

Oleksij Rempel posted 21 patches 1 year, 2 months ago
There is a newer version of this series
[PATCH net-next v1 04/21] net: usb: lan78xx: Improve error reporting with %pe specifier
Posted by Oleksij Rempel 1 year, 2 months ago
Replace integer error codes with the `%pe` format specifier in register
read and write error messages. This change provides human-readable error
strings, making logs more informative and debugging easier.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 drivers/net/usb/lan78xx.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index dd9b5d3abcb3..94320deaaeea 100644
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c
@@ -621,8 +621,8 @@ static int lan78xx_read_reg(struct lan78xx_net *dev, u32 index, u32 *data)
 		*data = *buf;
 	} else if (net_ratelimit()) {
 		netdev_warn(dev->net,
-			    "Failed to read register index 0x%08x. ret = %d",
-			    index, ret);
+			    "Failed to read register index 0x%08x. ret = %pe",
+			    index, ERR_PTR(ret));
 	}
 
 	kfree(buf);
@@ -652,8 +652,8 @@ static int lan78xx_write_reg(struct lan78xx_net *dev, u32 index, u32 data)
 	if (unlikely(ret < 0) &&
 	    net_ratelimit()) {
 		netdev_warn(dev->net,
-			    "Failed to write register index 0x%08x. ret = %d",
-			    index, ret);
+			    "Failed to write register index 0x%08x. ret = %pe",
+			    index, ERR_PTR(ret));
 	}
 
 	kfree(buf);
-- 
2.39.5
Re: [PATCH net-next v1 04/21] net: usb: lan78xx: Improve error reporting with %pe specifier
Posted by Andrew Lunn 1 year, 2 months ago
On Tue, Dec 03, 2024 at 08:21:37AM +0100, Oleksij Rempel wrote:
> Replace integer error codes with the `%pe` format specifier in register
> read and write error messages. This change provides human-readable error
> strings, making logs more informative and debugging easier.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew