[PATCH v2] tools/accounting/procacct: Fix minor errors

zhangjiao2 posted 1 patch 1 week, 1 day ago
tools/accounting/procacct.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
[PATCH v2] tools/accounting/procacct: Fix minor errors
Posted by zhangjiao2 1 week, 1 day ago
From: zhang jiao <zhangjiao2@cmss.chinamobile.com>

The logfile option was documented but not working.
Add it and optimized the while loop.

Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
Reviewed-by: Dr. Thomas Orgis <thomas.orgis@uni-hamburg.de>
---
v1->v2:
	Add logfile option.

 tools/accounting/procacct.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tools/accounting/procacct.c b/tools/accounting/procacct.c
index 90c4a37f53d9..e8dee05a6264 100644
--- a/tools/accounting/procacct.c
+++ b/tools/accounting/procacct.c
@@ -274,12 +274,11 @@ int main(int argc, char *argv[])
 	int maskset = 0;
 	char *logfile = NULL;
 	int cfd = 0;
-	int forking = 0;
 
 	struct msgtemplate msg;
 
-	while (!forking) {
-		c = getopt(argc, argv, "m:vr:");
+	while (1) {
+		c = getopt(argc, argv, "m:vr:w:");
 		if (c < 0)
 			break;
 
-- 
2.33.0
Re: [PATCH v2] tools/accounting/procacct: Fix minor errors
Posted by Dr. Thomas Orgis 1 week ago
> Reviewed-by: Dr. Thomas Orgis <thomas.orgis@uni-hamburg.de>

I repeat. Thanks for picking it up.


Alrighty then,

Thomas

-- 
Dr. Thomas Orgis
HPC @ Universität Hamburg