jbd2: two straightforward fixes

[PATCH 1/2] jbd2: increase IO priority for writing revoke records

Posted by Zhang Yi 1 day, 17 hours ago

From: Zhang Yi <yi.zhang@huawei.com>

Commit '6a3afb6ac6df ("jbd2: increase the journal IO's priority")'
increases the priority of journal I/O by marking I/O with the
JBD2_JOURNAL_REQ_FLAGS. However, that commit missed the revoke buffers,
so also addresses that kind of I/Os.

Fixes: 6a3afb6ac6df ("jbd2: increase the journal IO's priority")
Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
---
 fs/jbd2/revoke.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/jbd2/revoke.c b/fs/jbd2/revoke.c
index 4556e4689024..ce63d5fde9c3 100644
--- a/fs/jbd2/revoke.c
+++ b/fs/jbd2/revoke.c
@@ -654,7 +654,7 @@ static void flush_descriptor(journal_t *journal,
 	set_buffer_jwrite(descriptor);
 	BUFFER_TRACE(descriptor, "write");
 	set_buffer_dirty(descriptor);
-	write_dirty_buffer(descriptor, REQ_SYNC);
+	write_dirty_buffer(descriptor, JBD2_JOURNAL_REQ_FLAGS);
 }
 #endif
 
-- 
2.46.1

Re: [PATCH 1/2] jbd2: increase IO priority for writing revoke records

Posted by Jan Kara 1 day, 4 hours ago

On Tue 03-12-24 09:44:06, Zhang Yi wrote:
> From: Zhang Yi <yi.zhang@huawei.com>
> 
> Commit '6a3afb6ac6df ("jbd2: increase the journal IO's priority")'
> increases the priority of journal I/O by marking I/O with the
> JBD2_JOURNAL_REQ_FLAGS. However, that commit missed the revoke buffers,
> so also addresses that kind of I/Os.
> 
> Fixes: 6a3afb6ac6df ("jbd2: increase the journal IO's priority")
> Signed-off-by: Zhang Yi <yi.zhang@huawei.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/jbd2/revoke.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/jbd2/revoke.c b/fs/jbd2/revoke.c
> index 4556e4689024..ce63d5fde9c3 100644
> --- a/fs/jbd2/revoke.c
> +++ b/fs/jbd2/revoke.c
> @@ -654,7 +654,7 @@ static void flush_descriptor(journal_t *journal,
>  	set_buffer_jwrite(descriptor);
>  	BUFFER_TRACE(descriptor, "write");
>  	set_buffer_dirty(descriptor);
> -	write_dirty_buffer(descriptor, REQ_SYNC);
> +	write_dirty_buffer(descriptor, JBD2_JOURNAL_REQ_FLAGS);
>  }
>  #endif
>  
> -- 
> 2.46.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Re: [PATCH 1/2] jbd2: increase IO priority for writing revoke records

Posted by Kemeng Shi 1 day, 12 hours ago


on 12/3/2024 9:44 AM, Zhang Yi wrote:
> From: Zhang Yi <yi.zhang@huawei.com>
> 
> Commit '6a3afb6ac6df ("jbd2: increase the journal IO's priority")'
> increases the priority of journal I/O by marking I/O with the
> JBD2_JOURNAL_REQ_FLAGS. However, that commit missed the revoke buffers,
> so also addresses that kind of I/Os.
> 
> Fixes: 6a3afb6ac6df ("jbd2: increase the journal IO's priority")
> Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
> ---
>  fs/jbd2/revoke.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/jbd2/revoke.c b/fs/jbd2/revoke.c
> index 4556e4689024..ce63d5fde9c3 100644
> --- a/fs/jbd2/revoke.c
> +++ b/fs/jbd2/revoke.c
> @@ -654,7 +654,7 @@ static void flush_descriptor(journal_t *journal,
>  	set_buffer_jwrite(descriptor);
>  	BUFFER_TRACE(descriptor, "write");
>  	set_buffer_dirty(descriptor);
> -	write_dirty_buffer(descriptor, REQ_SYNC);
> +	write_dirty_buffer(descriptor, JBD2_JOURNAL_REQ_FLAGS);
>  }
>  #endif
Look good to me. Feel free to add:

Reviewed-by: Kemeng Shi <shikemeng@huaweicloud.com>