1. Patchew
  2. linux
  3. [PATCH 0/9] drm: Add DSI/DP support for Renesas r8a779h0 V4M and grey-hawk board
  4. View patch

[PATCH 2/9] dt-bindings: display: renesas,du: Add r8a779h0

Tomi Valkeinen posted 9 patches 1 year, 2 months ago
There is a newer version of this series
[PATCH 2/9] dt-bindings: display: renesas,du: Add r8a779h0
Posted by Tomi Valkeinen 1 year, 2 months ago 
From: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>

Extend the Renesas DU display bindings to support the r8a779h0 V4M.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
---
 Documentation/devicetree/bindings/display/renesas,du.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml
index c5b9e6812bce..d369953f16f7 100644
--- a/Documentation/devicetree/bindings/display/renesas,du.yaml
+++ b/Documentation/devicetree/bindings/display/renesas,du.yaml
@@ -41,6 +41,7 @@ properties:
       - renesas,du-r8a77995 # for R-Car D3 compatible DU
       - renesas,du-r8a779a0 # for R-Car V3U compatible DU
       - renesas,du-r8a779g0 # for R-Car V4H compatible DU
+      - renesas,du-r8a779h0 # for R-Car V4M compatible DU
 
   reg:
     maxItems: 1

-- 
2.43.0
Re: [PATCH 2/9] dt-bindings: display: renesas,du: Add r8a779h0
Posted by Laurent Pinchart 1 year, 2 months ago 
Hi Tomi,

Thank you for the patch.

On Tue, Dec 03, 2024 at 10:01:36AM +0200, Tomi Valkeinen wrote:
> From: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
> 
> Extend the Renesas DU display bindings to support the r8a779h0 V4M.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
> ---
>  Documentation/devicetree/bindings/display/renesas,du.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml
> index c5b9e6812bce..d369953f16f7 100644
> --- a/Documentation/devicetree/bindings/display/renesas,du.yaml
> +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml
> @@ -41,6 +41,7 @@ properties:
>        - renesas,du-r8a77995 # for R-Car D3 compatible DU
>        - renesas,du-r8a779a0 # for R-Car V3U compatible DU
>        - renesas,du-r8a779g0 # for R-Car V4H compatible DU
> +      - renesas,du-r8a779h0 # for R-Car V4M compatible DU
>  
>    reg:
>      maxItems: 1

You also need to add h0 to the g0 block in the conditional properties
below. With that,

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

-- 
Regards,

Laurent Pinchart
Re: [PATCH 2/9] dt-bindings: display: renesas,du: Add r8a779h0
Posted by Geert Uytterhoeven 1 year, 2 months ago 
Hi Laurent,

On Tue, Dec 3, 2024 at 9:19 AM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Tue, Dec 03, 2024 at 10:01:36AM +0200, Tomi Valkeinen wrote:
> > From: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
> >
> > Extend the Renesas DU display bindings to support the r8a779h0 V4M.
> >
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
> > ---
> >  Documentation/devicetree/bindings/display/renesas,du.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml
> > index c5b9e6812bce..d369953f16f7 100644
> > --- a/Documentation/devicetree/bindings/display/renesas,du.yaml
> > +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml
> > @@ -41,6 +41,7 @@ properties:
> >        - renesas,du-r8a77995 # for R-Car D3 compatible DU
> >        - renesas,du-r8a779a0 # for R-Car V3U compatible DU
> >        - renesas,du-r8a779g0 # for R-Car V4H compatible DU
> > +      - renesas,du-r8a779h0 # for R-Car V4M compatible DU
> >
> >    reg:
> >      maxItems: 1
>
> You also need to add h0 to the g0 block in the conditional properties
> below. With that,

Which is not sufficient, as the DU on R-Car V4M has only a single channel,
unlike on R-Car V3U and V4H.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Re: [PATCH 2/9] dt-bindings: display: renesas,du: Add r8a779h0
Posted by Laurent Pinchart 1 year, 2 months ago 
On Tue, Dec 03, 2024 at 09:38:44AM +0100, Geert Uytterhoeven wrote:
> Hi Laurent,
> 
> On Tue, Dec 3, 2024 at 9:19 AM Laurent Pinchart
> <laurent.pinchart@ideasonboard.com> wrote:
> > On Tue, Dec 03, 2024 at 10:01:36AM +0200, Tomi Valkeinen wrote:
> > > From: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
> > >
> > > Extend the Renesas DU display bindings to support the r8a779h0 V4M.
> > >
> > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
> > > ---
> > >  Documentation/devicetree/bindings/display/renesas,du.yaml | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml
> > > index c5b9e6812bce..d369953f16f7 100644
> > > --- a/Documentation/devicetree/bindings/display/renesas,du.yaml
> > > +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml
> > > @@ -41,6 +41,7 @@ properties:
> > >        - renesas,du-r8a77995 # for R-Car D3 compatible DU
> > >        - renesas,du-r8a779a0 # for R-Car V3U compatible DU
> > >        - renesas,du-r8a779g0 # for R-Car V4H compatible DU
> > > +      - renesas,du-r8a779h0 # for R-Car V4M compatible DU
> > >
> > >    reg:
> > >      maxItems: 1
> >
> > You also need to add h0 to the g0 block in the conditional properties
> > below. With that,
> 
> Which is not sufficient, as the DU on R-Car V4M has only a single channel,
> unlike on R-Car V3U and V4H.

Ah, indeed, in that case the DT bindings also need to take that into
account :-)

-- 
Regards,

Laurent Pinchart
Re: [PATCH 2/9] dt-bindings: display: renesas,du: Add r8a779h0
Posted by Tomi Valkeinen 1 year, 2 months ago 
On 03/12/2024 10:19, Laurent Pinchart wrote:
> Hi Tomi,
> 
> Thank you for the patch.
> 
> On Tue, Dec 03, 2024 at 10:01:36AM +0200, Tomi Valkeinen wrote:
>> From: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
>>
>> Extend the Renesas DU display bindings to support the r8a779h0 V4M.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
>> ---
>>   Documentation/devicetree/bindings/display/renesas,du.yaml | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml
>> index c5b9e6812bce..d369953f16f7 100644
>> --- a/Documentation/devicetree/bindings/display/renesas,du.yaml
>> +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml
>> @@ -41,6 +41,7 @@ properties:
>>         - renesas,du-r8a77995 # for R-Car D3 compatible DU
>>         - renesas,du-r8a779a0 # for R-Car V3U compatible DU
>>         - renesas,du-r8a779g0 # for R-Car V4H compatible DU
>> +      - renesas,du-r8a779h0 # for R-Car V4M compatible DU
>>   
>>     reg:
>>       maxItems: 1
> 
> You also need to add h0 to the g0 block in the conditional properties
> below. With that,

Ah, I missed that. Thanks.

  Tomi

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.