[v1] Input: joystick - use str_off_on() helper in sw_connect()

[PATCH] Input: joystick - use str_off_on() helper in sw_connect()

Thorsten Blum posted 1 patch 1 year, 2 months ago

Diff against v1
Download mbox

There is a newer version of this series

drivers/input/joystick/sidewinder.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH] Input: joystick - use str_off_on() helper in sw_connect()

Posted by Thorsten Blum 1 year, 2 months ago

Remove hard-coded strings by using the str_off_on() helper.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 drivers/input/joystick/sidewinder.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/input/joystick/sidewinder.c b/drivers/input/joystick/sidewinder.c
index f6e92db4d789..3a5873e5fcb3 100644
--- a/drivers/input/joystick/sidewinder.c
+++ b/drivers/input/joystick/sidewinder.c
@@ -14,6 +14,7 @@
 #include <linux/input.h>
 #include <linux/gameport.h>
 #include <linux/jiffies.h>
+#include <linux/string_choices.h>
 
 #define DRIVER_DESC	"Microsoft SideWinder joystick family driver"
 
@@ -677,7 +678,7 @@ static int sw_connect(struct gameport *gameport, struct gameport_driver *drv)
 				case 48:				/* Ambiguous */
 					if (j == 14) {			/* ID length 14*3 -> FFP */
 						sw->type = SW_ID_FFP;
-						sprintf(comment, " [AC %s]", sw_get_bits(idbuf,38,1,3) ? "off" : "on");
+						sprintf(comment, " [AC %s]", str_off_on(sw_get_bits(idbuf,38,1,3)));
 					} else
 						sw->type = SW_ID_PP;
 					break;
-- 
2.47.0

Re: [PATCH] Input: joystick - use str_off_on() helper in sw_connect()

Posted by Dmitry Torokhov 1 year ago

On Mon, Dec 02, 2024 at 04:46:00PM +0100, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_off_on() helper.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

Applied, thank you.

-- 
Dmitry