[PATCH 09/10] arm64: dts: qcom: sm8650: add support for QTEE

Amirreza Zarrabi posted 10 patches 1 day, 14 hours ago
[PATCH 09/10] arm64: dts: qcom: sm8650: add support for QTEE
Posted by Amirreza Zarrabi 1 day, 14 hours ago
Add qcom_tee node.

Signed-off-by: Amirreza Zarrabi <quic_azarrabi@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sm8650.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
index 25e47505adcb..41505b032e3a 100644
--- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
@@ -372,6 +372,10 @@ scm: scm {
 			interconnects = <&aggre2_noc MASTER_CRYPTO QCOM_ICC_TAG_ALWAYS
 					 &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
 		};
+
+		qcom_tee {
+			compatible = "qcom,tee";
+		};
 	};
 
 	clk_virt: interconnect-0 {

-- 
2.34.1
Re: [PATCH 09/10] arm64: dts: qcom: sm8650: add support for QTEE
Posted by Krzysztof Kozlowski 1 day, 10 hours ago
On 03/12/2024 05:19, Amirreza Zarrabi wrote:
> Add qcom_tee node.

Why? "What" we see from the diff. Stop repeating subjects, but say
something useful. This applies to all your patches.

Anyway, your driver and binding say that this is just a fake node used
purely to instantiate the Linux driver. Drop the patch.


Best regards,
Krzysztof
Re: [PATCH 09/10] arm64: dts: qcom: sm8650: add support for QTEE
Posted by Amirreza Zarrabi 17 hours ago

On 12/3/2024 6:59 PM, Krzysztof Kozlowski wrote:
> On 03/12/2024 05:19, Amirreza Zarrabi wrote:
>> Add qcom_tee node.
> 
> Why? "What" we see from the diff. Stop repeating subjects, but say
> something useful. This applies to all your patches.
> 
> Anyway, your driver and binding say that this is just a fake node used
> purely to instantiate the Linux driver. Drop the patch.
> 

Hi Krzysztof,

Thank you so much for your comments. I totally understand.
I'll remove the fake node.

Best Regards,
Amir

> 
> Best regards,
> Krzysztof