[PATCH v2 27/31] arm64: dts: qcom: sm6375: move board clocks to sm6375.dtsi file

Dmitry Baryshkov posted 31 patches 3 weeks, 5 days ago
[PATCH v2 27/31] arm64: dts: qcom: sm6375: move board clocks to sm6375.dtsi file
Posted by Dmitry Baryshkov 3 weeks, 5 days ago
SM6375 platform has main XO clock definition split between the SoC dtsi
file and the board file.
This is not optimal, as the clocks are a part of the SoC + PMICs design.
Frequencies are common for the whole set of devices using the same SoC.
Remove the split and move frequencies to the SoC DTSI file.

Suggested-by: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts | 4 ----
 arch/arm64/boot/dts/qcom/sm6375.dtsi                          | 1 +
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts b/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts
index e04a3b8f81c556713550cd22feb2d0f282564baa..9840868fc7196316bbf9d2de9b8967ba73e541d9 100644
--- a/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts
+++ b/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts
@@ -454,7 +454,3 @@ &wifi {
 	vdd-3.3-ch1-supply = <&pm6125_l21>;
 	status = "okay";
 };
-
-&xo_board_clk {
-	clock-frequency = <19200000>;
-};
diff --git a/arch/arm64/boot/dts/qcom/sm6375.dtsi b/arch/arm64/boot/dts/qcom/sm6375.dtsi
index 7c929168ed0805e832b818516083d48968d3bbce..013666efbbe8b5b9c12f3d7dcab0b59de8a69c50 100644
--- a/arch/arm64/boot/dts/qcom/sm6375.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6375.dtsi
@@ -25,6 +25,7 @@ clocks {
 		xo_board_clk: xo-board-clk {
 			compatible = "fixed-clock";
 			#clock-cells = <0>;
+			clock-frequency = <19200000>;
 		};
 
 		sleep_clk: sleep-clk {

-- 
2.39.5
Re: [PATCH v2 27/31] arm64: dts: qcom: sm6375: move board clocks to sm6375.dtsi file
Posted by Krzysztof Kozlowski 3 weeks, 5 days ago
On 30/11/2024 02:44, Dmitry Baryshkov wrote:
> SM6375 platform has main XO clock definition split between the SoC dtsi
> file and the board file.
> This is not optimal, as the clocks are a part of the SoC + PMICs design.
> Frequencies are common for the whole set of devices using the same SoC.
> Remove the split and move frequencies to the SoC DTSI file.
> 
> Suggested-by: Bjorn Andersson <andersson@kernel.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---


Nacked-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof