[PATCH v2] misc: Kconfig: Make MCHP_LAN966X_PCI depend on OF_OVERLAY

Ricardo Ribalda posted 1 patch 3 weeks, 5 days ago
drivers/misc/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[PATCH v2] misc: Kconfig: Make MCHP_LAN966X_PCI depend on OF_OVERLAY
Posted by Ricardo Ribalda 3 weeks, 5 days ago
Drivers should depend on configurations that can be user-configurable
instead of selecting them.

Without this patch, OF cannot be disabled this way:
make allyesconfig
scripts/config -d OF
make olddefconfig

Which is a typical test in CI systems like media-ci.

Now that we are at it, remove the dependency on OF, it will come
automatically from OF_OVERLAY.

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
Changes in v2:
- Depend on OF_OVERLAY also
- Link to v1: https://lore.kernel.org/r/20241129-lan966x-depend-v1-1-603fc4996c4f@chromium.org
---
 drivers/misc/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 902c306bc972..d617105fbda7 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -613,8 +613,7 @@ config MARVELL_CN10K_DPI
 config MCHP_LAN966X_PCI
 	tristate "Microchip LAN966x PCIe Support"
 	depends on PCI
-	select OF
-	select OF_OVERLAY
+	depends on OF_OVERLAY
 	select IRQ_DOMAIN
 	help
 	  This enables the support for the LAN966x PCIe device.

---
base-commit: 7af08b57bcb9ebf78675c50069c54125c0a8b795
change-id: 20241129-lan966x-depend-8bc69b4954e5

Best regards,
-- 
Ricardo Ribalda <ribalda@chromium.org>