[PATCH] dt-bindings: iio: accel: fxls8962af: add wakeup-source property

Sean Nyekjaer posted 1 patch 1 year, 2 months ago
There is a newer version of this series
Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml | 6 ++++++
1 file changed, 6 insertions(+)
[PATCH] dt-bindings: iio: accel: fxls8962af: add wakeup-source property
Posted by Sean Nyekjaer 1 year, 2 months ago
Add the wakeup-source to enable this device as a wakeup source if
defined in DT.

Signed-off-by: Sean Nyekjaer <sean@geanix.com>
---
 Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml b/Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml
index 2d99e3811da07ea0453feafbcf82a227185ecea2..c175f4c4cbdb8f8debb0fe64ed21157f3a878d59 100644
--- a/Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml
+++ b/Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml
@@ -46,6 +46,11 @@ properties:
   drive-open-drain:
     type: boolean
 
+  wakeup-source:
+    $ref: /schemas/types.yaml#/definitions/flag
+    description:
+      Enable wake on accelerometer event
+
 required:
   - compatible
   - reg
@@ -69,6 +74,7 @@ examples:
             interrupt-parent = <&gpio0>;
             interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
             interrupt-names = "INT1";
+            wakeup-source;
         };
     };
   - |

---
base-commit: a61ff7eac77e86de828fe28c4e42b8ae9ec2b195
change-id: 20241129-fxlsdt-2012530ca076

Best regards,
-- 
Sean Nyekjaer <sean@geanix.com>
Re: [PATCH] dt-bindings: iio: accel: fxls8962af: add wakeup-source property
Posted by Krzysztof Kozlowski 1 year, 2 months ago
On Fri, Nov 29, 2024 at 04:01:24PM +0100, Sean Nyekjaer wrote:
> Add the wakeup-source to enable this device as a wakeup source if
> defined in DT.

That's a circular argument. Especially last part "if ...".

Explain the hardware aspects / reasoning.

Best regards,
Krzysztof
Re: [PATCH] dt-bindings: iio: accel: fxls8962af: add wakeup-source property
Posted by Sean Nyekjaer 1 year, 2 months ago
Thanks Krzysztof

On Sat, Nov 30, 2024 at 10:56:06AM +0100, Krzysztof Kozlowski wrote:
> On Fri, Nov 29, 2024 at 04:01:24PM +0100, Sean Nyekjaer wrote:
> > Add the wakeup-source to enable this device as a wakeup source if
> > defined in DT.
> 
> That's a circular argument. Especially last part "if ...".
> 
> Explain the hardware aspects / reasoning.

Is something like this better?

    Add a wakeup-source property to the binding to describe whether the
    wakeup interrupts from the accelerometer can wake the system from
    suspend.

/Sean