[PATCH 8/9] sched/fair: Fix sched_can_stop_tick() for fair tasks

Vincent Guittot posted 9 patches 1 year, 2 months ago
There is a newer version of this series
[PATCH 8/9] sched/fair: Fix sched_can_stop_tick() for fair tasks
Posted by Vincent Guittot 1 year, 2 months ago
We can't stop the tick of a rq if there are at least 2 tasks enqueued in
the whole hierarchy and not only at the root cfs rq.

rq->cfs.nr_running tracks the number of sched_entity at one level
whereas rq->cfs.h_nr_enqueued tracks all enqueued tasks in the
hierarchy.

Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
---
 kernel/sched/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index daaa20f01ad4..263e0b9bb7d5 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -1341,7 +1341,7 @@ bool sched_can_stop_tick(struct rq *rq)
 	if (scx_enabled() && !scx_can_stop_tick(rq))
 		return false;
 
-	if (rq->cfs.nr_enqueued > 1)
+	if (rq->cfs.h_nr_enqueued > 1)
 		return false;
 
 	/*
-- 
2.43.0