fat: use nls_tolower simplify code

[PATCH] fat: use nls_tolower simplify code

Posted by Wang Jianjian 1 year, 2 months ago

Signed-off-by: Wang Jianjian <wangjianjian3@huawei.com>
---
 fs/fat/dir.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/fs/fat/dir.c b/fs/fat/dir.c
index acbec5bdd521..88bf16204aab 100644
--- a/fs/fat/dir.c
+++ b/fs/fat/dir.c
@@ -214,10 +214,7 @@ fat_short2lower_uni(struct nls_table *t, unsigned char *c,
 		*uni = 0x003f;	/* a question mark */
 		charlen = 1;
 	} else if (charlen <= 1) {
-		unsigned char nc = t->charset2lower[*c];
-
-		if (!nc)
-			nc = *c;
+		unsigned char nc = nls_tolower(t, *c);
 
 		charlen = t->char2uni(&nc, 1, uni);
 		if (charlen < 0) {
-- 
2.34.1

Re: [PATCH] fat: use nls_tolower simplify code

Posted by Markus Elfring 1 year, 2 months ago

Will another change description be helpful?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12#n45

Regards,
Markus

Re: [PATCH] fat: use nls_tolower simplify code

Posted by OGAWA Hirofumi 1 year, 2 months ago

Wang Jianjian <wangjianjian3@huawei.com> writes:

> Signed-off-by: Wang Jianjian <wangjianjian3@huawei.com>

Looks good. Thanks.

Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

> ---
>  fs/fat/dir.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/fs/fat/dir.c b/fs/fat/dir.c
> index acbec5bdd521..88bf16204aab 100644
> --- a/fs/fat/dir.c
> +++ b/fs/fat/dir.c
> @@ -214,10 +214,7 @@ fat_short2lower_uni(struct nls_table *t, unsigned char *c,
>  		*uni = 0x003f;	/* a question mark */
>  		charlen = 1;
>  	} else if (charlen <= 1) {
> -		unsigned char nc = t->charset2lower[*c];
> -
> -		if (!nc)
> -			nc = *c;
> +		unsigned char nc = nls_tolower(t, *c);
>  
>  		charlen = t->char2uni(&nc, 1, uni);
>  		if (charlen < 0) {

-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>