can: tcan4x5x: get rid of false clock errors

[PATCH] can: tcan4x5x: get rid of false clock errors

Posted by Sean Nyekjaer 1 year, 2 months ago

tcan4x5x devices only requires one clock cclk, so call devm_clk_get()
directly. This is done to avoid m_can_class_get_clocks() that checks for
both hclk and cclk.

tcan4x5x spi0.0: no clock found

Signed-off-by: Sean Nyekjaer <sean@geanix.com>
---
 drivers/net/can/m_can/tcan4x5x-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/can/m_can/tcan4x5x-core.c b/drivers/net/can/m_can/tcan4x5x-core.c
index 7213d9894c82d079bf92f1ec62d4eebb500cdfa4..7463c40b909873b9c5bcc753f9db7009e9d66008 100644
--- a/drivers/net/can/m_can/tcan4x5x-core.c
+++ b/drivers/net/can/m_can/tcan4x5x-core.c
@@ -410,7 +410,7 @@ static int tcan4x5x_can_probe(struct spi_device *spi)
 		priv->power = NULL;
 	}
 
-	m_can_class_get_clocks(mcan_class);
+	mcan_class->cclk = devm_clk_get(mcan_class->dev, "cclk");
 	if (IS_ERR(mcan_class->cclk)) {
 		dev_err(&spi->dev, "no CAN clock source defined\n");
 		freq = TCAN4X5X_EXT_CLK_DEF;

---
base-commit: e0b741bc53c94f9ae25d4140202557a0aa51b5a0
change-id: 20241127-mcancclk-741d21afcb29

Best regards,
-- 
Sean Nyekjaer <sean@geanix.com>

Re: [PATCH] can: tcan4x5x: get rid of false clock errors

Posted by Marc Kleine-Budde 1 year, 2 months ago

On 28.11.2024 09:32:31, Sean Nyekjaer wrote:
> tcan4x5x devices only requires one clock cclk, so call devm_clk_get()
> directly. This is done to avoid m_can_class_get_clocks() that checks for
> both hclk and cclk.
> 
> tcan4x5x spi0.0: no clock found
> 
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>

Applied to linux-can-next/testing

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |