dt-bindings: usb: max33359: add max77759 flavor

[PATCH] dt-bindings: usb: max33359: add max77759 flavor

Posted by André Draszik 1 year, 2 months ago

On the surface, Maxim's max77759 appears identical to max33359. It
should still have a dedicated compatible, though, as it is a different
IC. This will allow for handling differences in case they are
discovered in the future.

max77759 is used on Google Pixel 6 and Pixel 6 Pro.

Add a dedicated compatible to allow for potential differences in the
future.

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
v2:
* collect tags
* split out from original series (Krzysztof)
* link to original series
  https://lore.kernel.org/all/20241127-gs101-phy-lanes-orientation-dts-v1-2-5222d8508b71@linaro.org/
---
 Documentation/devicetree/bindings/usb/maxim,max33359.yaml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml
index 20b62228371b..e11ede3684d4 100644
--- a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml
+++ b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml
@@ -13,8 +13,12 @@ description: Maxim TCPCI Type-C PD controller
 
 properties:
   compatible:
-    enum:
-      - maxim,max33359
+    oneOf:
+      - enum:
+          - maxim,max33359
+      - items:
+          - const: maxim,max77759
+          - const: maxim,max33359
 
   reg:
     maxItems: 1

---
base-commit: ed9a4ad6e5bd3a443e81446476718abebee47e82
change-id: 20241128-dtbinding-max77759-b3ddbd264544

Best regards,
-- 
André Draszik <andre.draszik@linaro.org>

Re: [PATCH] dt-bindings: usb: max33359: add max77759 flavor

Posted by Peter Griffin 1 year, 2 months ago

Hi André,

On Thu, 28 Nov 2024 at 08:51, André Draszik <andre.draszik@linaro.org> wrote:
>
> On the surface, Maxim's max77759 appears identical to max33359. It
> should still have a dedicated compatible, though, as it is a different
> IC. This will allow for handling differences in case they are
> discovered in the future.
>
> max77759 is used on Google Pixel 6 and Pixel 6 Pro.
>
> Add a dedicated compatible to allow for potential differences in the
> future.
>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---

Acked-by: Peter Griffin <peter.griffin@linaro.org>

regards,

Peter