[PATCH v4 1/2] dt-bindings: power: supply: Add STC3117 Fuel Gauge

Bhavin Sharma posted 2 patches 1 year, 2 months ago
There is a newer version of this series
[PATCH v4 1/2] dt-bindings: power: supply: Add STC3117 Fuel Gauge
Posted by Bhavin Sharma 1 year, 2 months ago
The STC3117 provides a simple fuel gauge via I2C.
Add a DT schema to describe how to set it up in the device tree.

Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>
Signed-off-by: Bhavin Sharma <bhavin.sharma@siliconsignals.io>
---
 .../bindings/power/supply/st,stc3117.yaml     | 53 +++++++++++++++++++
 1 file changed, 53 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/st,stc3117.yaml

diff --git a/Documentation/devicetree/bindings/power/supply/st,stc3117.yaml b/Documentation/devicetree/bindings/power/supply/st,stc3117.yaml
new file mode 100644
index 000000000000..06e53534ad76
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/supply/st,stc3117.yaml
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/power/supply/st,stc3117.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: STMicroelectronics STC3117 Fuel Gauge Unit Power Supply
+
+maintainers:
+  - Bhavin Sharma <bhavin.sharma@siliconsignals.io>
+  - Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>
+
+description: |
+  The STC3117 includes the STMicroelectronics OptimGauge algorithm.
+  It provides accurate battery state-of-charge (SOC) monitoring, tracks
+  battery parameter changes with operation conditions, temperature,
+  and aging, and allows the application to get a battery state-of-health
+  (SOH) indication.
+
+  An alarm output signals low SOC or low voltage conditions and also
+  indicates fault conditions like a missing or swapped battery.
+
+  Datasheet is available at
+  https://www.st.com/resource/en/datasheet/stc3117.pdf
+
+allOf:
+  - $ref: power-supply.yaml#
+
+properties:
+  compatible:
+    enum:
+      - st,stc3117
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      battery@70 {
+        compatible = "st,stc3117";
+        reg = <0x70>;
+      };
+    };
-- 
2.43.0
Re: [PATCH v4 1/2] dt-bindings: power: supply: Add STC3117 Fuel Gauge
Posted by Krzysztof Kozlowski 1 year, 2 months ago
On 27/11/2024 16:19, Bhavin Sharma wrote:
> +
> +allOf:
> +  - $ref: power-supply.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - st,stc3117
> +
> +  reg:
> +    maxItems: 1

I asked you some questions on v2, then on v3 and no responses.

You implemented some changes but still did not answer my question. I am
not going to ask again, obviously expecting different result on the same
makes little sense.

No ack from me.

Best regards,
Krzysztof
Re: [PATCH v4 1/2] dt-bindings: power: supply: Add STC3117 Fuel Gauge
Posted by Krzysztof Kozlowski 1 year, 2 months ago
On 27/11/2024 19:22, Krzysztof Kozlowski wrote:
> On 27/11/2024 16:19, Bhavin Sharma wrote:
>> +
>> +allOf:
>> +  - $ref: power-supply.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - st,stc3117
>> +
>> +  reg:
>> +    maxItems: 1
> 
> I asked you some questions on v2, then on v3 and no responses.
> 
> You implemented some changes but still did not answer my question. I am
> not going to ask again, obviously expecting different result on the same
> makes little sense.
> 
> No ack from me.
> 

You responded privately - I am not going to do any talks under NDA. I
also do not provide some sort of personal support service. Keep *ALL*
discussions public.

Explaining what you asked:

Some of these are from monitored-battery. Sense resistor should be
separate property. But different question is about missing resources,
like supplies (VCC) and interrupts. Just look at datasheet.

Best regards,
Krzysztof