Document Device Tree bindings for the Andes ATCRTC100 Real-Time Clock.
Signed-off-by: CL Wang <cl634@andestech.com>
---
Changes for v2:
- First version of devicetree bindings for the Andes ATCRTC100 Real-Time Clock.
Changes for v3:
- Used compatible as the filename.
- Placed allOf after maintainers.
- Replaced additionalProperties: false with unevaluatedProperties: false.
- Added descriptions for interrupts.
Changes for v4:
- Removed wakeup-source attribute.
---
.../bindings/rtc/andestech,atcrtc100.yaml | 43 +++++++++++++++++++
1 file changed, 43 insertions(+)
create mode 100644 Documentation/devicetree/bindings/rtc/andestech,atcrtc100.yaml
diff --git a/Documentation/devicetree/bindings/rtc/andestech,atcrtc100.yaml b/Documentation/devicetree/bindings/rtc/andestech,atcrtc100.yaml
new file mode 100644
index 000000000000..ec0a736793c7
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/andestech,atcrtc100.yaml
@@ -0,0 +1,43 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/andestech,atcrtc100.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Andes ATCRTC100 Real-Time Clock
+
+maintainers:
+ - CL Wang <cl634@andestech.com>
+
+allOf:
+ - $ref: rtc.yaml#
+
+properties:
+ compatible:
+ enum:
+ - andestech,atcrtc100
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ items:
+ - description: Periodic timekeeping interrupt
+ - description: RTC alarm interrupt
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ rtc@f0300000 {
+ compatible = "andestech,atcrtc100";
+ reg = <0xf0300000 0x100>;
+ interrupts = <1 IRQ_TYPE_LEVEL_HIGH>, <2 IRQ_TYPE_LEVEL_HIGH>;
+ };
--
2.34.1
On Wed, Nov 27, 2024 at 10:19:38PM +0800, CL Wang wrote: > Document Device Tree bindings for the Andes ATCRTC100 Real-Time Clock. > > Signed-off-by: CL Wang <cl634@andestech.com> > > --- > Changes for v2: > - First version of devicetree bindings for the Andes ATCRTC100 Real-Time Clock. > > Changes for v3: > - Used compatible as the filename. > - Placed allOf after maintainers. > - Replaced additionalProperties: false with unevaluatedProperties: false. > - Added descriptions for interrupts. > > Changes for v4: > - Removed wakeup-source attribute. > --- > .../bindings/rtc/andestech,atcrtc100.yaml | 43 +++++++++++++++++++ > 1 file changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/andestech,atcrtc100.yaml Missing Conor's tag from the 1st resend. If you got tags and need to resend, that's not a resend. You need to add the tags and it is v5. But don't just go send v5 now for that. Alexandre can add the tag. Rob
Hi Rob, Thank you for your review and comments. I will include the reviewer's tag in the next version of the patch. As you mentioned, if a tag is received and a resend is necessary, I will include the tags and update the revision to v5. Thank you again for your reminder. Best regards, CL On Tue, Dec 03, 2024 at 11:06:51AM -0600, Rob Herring wrote: > [EXTERNAL MAIL] > > On Wed, Nov 27, 2024 at 10:19:38PM +0800, CL Wang wrote: > > Document Device Tree bindings for the Andes ATCRTC100 Real-Time Clock. > > > > Signed-off-by: CL Wang <cl634@andestech.com> > > > > --- > > Changes for v2: > > - First version of devicetree bindings for the Andes ATCRTC100 Real-Time Clock. > > > > Changes for v3: > > - Used compatible as the filename. > > - Placed allOf after maintainers. > > - Replaced additionalProperties: false with unevaluatedProperties: false. > > - Added descriptions for interrupts. > > > > Changes for v4: > > - Removed wakeup-source attribute. > > --- > > .../bindings/rtc/andestech,atcrtc100.yaml | 43 +++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/rtc/andestech,atcrtc100.yaml > > Missing Conor's tag from the 1st resend. If you got tags and need to > resend, that's not a resend. You need to add the tags and it is v5. > > But don't just go send v5 now for that. Alexandre can add the tag. > > Rob
© 2016 - 2026 Red Hat, Inc.