[PATCH 1/4] dt-bindings: phy: Add eDP PHY compatible for qcs8300

Yongxing Mou posted 4 patches 1 year, 2 months ago
[PATCH 1/4] dt-bindings: phy: Add eDP PHY compatible for qcs8300
Posted by Yongxing Mou 1 year, 2 months ago
Add compatible string for the supported eDP PHY on qcs8300 platform.

Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
---
 Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
index 293fb6a9b1c330438bceba15226c91e392c840fb..e249aee9b11d58b8f2a9c8708285e0f2510bafc7 100644
--- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
@@ -17,6 +17,7 @@ description:
 properties:
   compatible:
     enum:
+      - qcom,qcs8300-edp-phy
       - qcom,sa8775p-edp-phy
       - qcom,sc7280-edp-phy
       - qcom,sc8180x-edp-phy

-- 
2.34.1
Re: [PATCH 1/4] dt-bindings: phy: Add eDP PHY compatible for qcs8300
Posted by Krzysztof Kozlowski 1 year, 2 months ago
On 27/11/2024 09:15, Yongxing Mou wrote:
> Add compatible string for the supported eDP PHY on qcs8300 platform.


What is supported eDP PHY? Can it be unsupported? Anyway, this repeats
the diff. Say something useful instead, like why this is not compatible
with sa8775p.

Best regards,
Krzysztof
Re: [PATCH 1/4] dt-bindings: phy: Add eDP PHY compatible for qcs8300
Posted by Yongxing Mou 1 year, 2 months ago

On 2024/11/28 2:28, Krzysztof Kozlowski wrote:
> On 27/11/2024 09:15, Yongxing Mou wrote:
>> Add compatible string for the supported eDP PHY on qcs8300 platform.
> 
> 
> What is supported eDP PHY? Can it be unsupported? Anyway, this repeats
> the diff. Say something useful instead, like why this is not compatible
> with sa8775p.
> 
> Best regards,
> Krzysztof

Actually,for edp phy,it is same with sa8775p, so will reuse it's driver 
in next patchset.so this patch should drop it..Thansk for reviewing.