Enable Display Port for Qualcomm QCS8300-ride platform

[PATCH 2/2] arm64: dts: qcom: qcs8300-ride: Enable Display Port

Posted by Yongxing Mou 1 year, 2 months ago

Enable DPTX0 along with their corresponding PHYs for
qcs8300-ride platform.

Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
---
 arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 44 +++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
index 7eed19a694c39dbe791afb6a991db65acb37e597..5dc855d6a22c38d97a3071d3a3d88ec551eebd1b 100644
--- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
@@ -35,6 +35,18 @@ sleep_clk: sleep-clk {
 			clock-frequency = <32000>;
 		};
 	};
+
+	dp0-connector {
+		compatible = "dp-connector";
+		label = "DP0";
+		type = "full-size";
+
+		port {
+			dp0_connector_in: endpoint {
+				remote-endpoint = <&mdss_dp0_out>;
+			};
+		};
+	};
 };
 
 &apps_rsc {
@@ -223,6 +235,30 @@ &gcc {
 		 <0>;
 };
 
+&mdss {
+	status = "okay";
+};
+
+&mdss_dp0 {
+	status = "okay";
+
+	pinctrl-0 = <&dp_hot_plug_det>;
+	pinctrl-names = "default";
+};
+
+&mdss_dp0_out {
+	data-lanes = <0 1 2 3>;
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+	remote-endpoint = <&dp0_connector_in>;
+};
+
+&mdss_dp0_phy {
+	status = "okay";
+
+	vdda-phy-supply = <&vreg_l5a>;
+	vdda-pll-supply = <&vreg_l4a>;
+};
+
 &qupv3_id_0 {
 	status = "okay";
 };
@@ -247,6 +283,14 @@ &rpmhcc {
 	clock-names = "xo";
 };
 
+&tlmm {
+	dp_hot_plug_det: dp-hot-plug-det-state {
+		pins = "gpio94";
+		function = "edp0_hot";
+		bias-disable;
+	};
+};
+
 &uart7 {
 	status = "okay";
 };

-- 
2.34.1

Re: [PATCH 2/2] arm64: dts: qcom: qcs8300-ride: Enable Display Port

Posted by Konrad Dybcio 1 year, 2 months ago

On 27.11.2024 11:45 AM, Yongxing Mou wrote:
> Enable DPTX0 along with their corresponding PHYs for
> qcs8300-ride platform.
> 
> Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
> ---

[...]

> +
> +	dp0-connector {
> +		compatible = "dp-connector";
> +		label = "DP0";
> +		type = "full-size";

I was surprised to see it but yeah this is real

> +
> +		port {
> +			dp0_connector_in: endpoint {
> +				remote-endpoint = <&mdss_dp0_out>;
> +			};
> +		};
> +	};
>  };
>  
>  &apps_rsc {
> @@ -223,6 +235,30 @@ &gcc {
>  		 <0>;
>  };
>  
> +&mdss {
> +	status = "okay";
> +};
> +
> +&mdss_dp0 {
> +	status = "okay";
status should be the last property

> +
> +	pinctrl-0 = <&dp_hot_plug_det>;
> +	pinctrl-names = "default";
> +};
> +
> +&mdss_dp0_out {
> +	data-lanes = <0 1 2 3>;
> +	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
> +	remote-endpoint = <&dp0_connector_in>;
> +};
> +
> +&mdss_dp0_phy {
> +	status = "okay";
> +
> +	vdda-phy-supply = <&vreg_l5a>;
> +	vdda-pll-supply = <&vreg_l4a>;
I couldn't find the reference for these, so I have to trust you

Konrad

Re: [PATCH 2/2] arm64: dts: qcom: qcs8300-ride: Enable Display Port

Posted by Yongxing Mou 1 year, 1 month ago


On 2024/12/6 5:46, Konrad Dybcio wrote:
> On 27.11.2024 11:45 AM, Yongxing Mou wrote:
>> Enable DPTX0 along with their corresponding PHYs for
>> qcs8300-ride platform.
>>
>> Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
>> ---
> 
> [...]
> 
>> +
>> +	dp0-connector {
>> +		compatible = "dp-connector";
>> +		label = "DP0";
>> +		type = "full-size";
> 
> I was surprised to see it but yeah this is real
> 
>> +
>> +		port {
>> +			dp0_connector_in: endpoint {
>> +				remote-endpoint = <&mdss_dp0_out>;
>> +			};
>> +		};
>> +	};
>>   };
>>   
>>   &apps_rsc {
>> @@ -223,6 +235,30 @@ &gcc {
>>   		 <0>;
>>   };
>>   
>> +&mdss {
>> +	status = "okay";
>> +};
>> +
>> +&mdss_dp0 {
>> +	status = "okay";
> status should be the last property
> 
got it. thanks for ponit it.
>> +
>> +	pinctrl-0 = <&dp_hot_plug_det>;
>> +	pinctrl-names = "default";
>> +};
>> +
>> +&mdss_dp0_out {
>> +	data-lanes = <0 1 2 3>;
>> +	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
>> +	remote-endpoint = <&dp0_connector_in>;
>> +};
>> +
>> +&mdss_dp0_phy {
>> +	status = "okay";
>> +
>> +	vdda-phy-supply = <&vreg_l5a>;
>> +	vdda-pll-supply = <&vreg_l4a>;
> I couldn't find the reference for these, so I have to trust you
> 
yes, this two power can work for qcs8300.and we verify it.status also 
should be last property?
> Konrad
>

Re: [PATCH 2/2] arm64: dts: qcom: qcs8300-ride: Enable Display Port

Posted by Konrad Dybcio 1 year, 1 month ago

On 26.12.2024 8:06 AM, Yongxing Mou wrote:
> 
> 
> On 2024/12/6 5:46, Konrad Dybcio wrote:
>> On 27.11.2024 11:45 AM, Yongxing Mou wrote:
>>> Enable DPTX0 along with their corresponding PHYs for
>>> qcs8300-ride platform.
>>>
>>> Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
>>> ---

[...]
>>> +
>>> +&mdss_dp0_out {
>>> +    data-lanes = <0 1 2 3>;
>>> +    link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
>>> +    remote-endpoint = <&dp0_connector_in>;
>>> +};
>>> +
>>> +&mdss_dp0_phy {
>>> +    status = "okay";
>>> +
>>> +    vdda-phy-supply = <&vreg_l5a>;
>>> +    vdda-pll-supply = <&vreg_l4a>;
>> I couldn't find the reference for these, so I have to trust you
>>
> yes, this two power can work for qcs8300.and we verify it.status also should be last property?

Yep, it should be the last one, everywhere

Konrad