[PATCH v2 0/2] kbuild: propagate CONFIG_WERROR to resolve_btfids

Thomas Weißschuh posted 2 patches 1 year, 2 months ago
There is a newer version of this series
scripts/link-vmlinux.sh         |  6 +++++-
tools/bpf/resolve_btfids/main.c | 12 ++++++++++--
2 files changed, 15 insertions(+), 3 deletions(-)
[PATCH v2 0/2] kbuild: propagate CONFIG_WERROR to resolve_btfids
Posted by Thomas Weißschuh 1 year, 2 months ago
Use CONFIG_WERROR to also fail on warnings emitted by resolve_btfids.
Allow the CI bots to prevent the introduction of new warnings.

This series currently depends on
"[PATCH] bpf, lsm: Fix getlsmprop hooks BTF IDs" [0]

[0] https://lore.kernel.org/lkml/20241123-bpf_lsm_task_getsecid_obj-v1-1-0d0f94649e05@weissschuh.net/

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
Changes in v2:
- Avoid uninitialized read of fatal_warnings
- Use OPT_BOOLEAN over OPT_INCR
- Drop dependency patch, which went in via the kbuild tree
- Link to v1: https://lore.kernel.org/r/20241123-resolve_btfids-v1-0-927700b641d1@weissschuh.net

---
Thomas Weißschuh (2):
      tools/resolve_btfids: Add --fatal-warnings option
      kbuild: propagate CONFIG_WERROR to resolve_btfids

 scripts/link-vmlinux.sh         |  6 +++++-
 tools/bpf/resolve_btfids/main.c | 12 ++++++++++--
 2 files changed, 15 insertions(+), 3 deletions(-)
---
base-commit: 1518b7a61299cf3737728d4fbf7e29cf2db497c7
change-id: 20241123-resolve_btfids-eb95c9b42d00

Best regards,
-- 
Thomas Weißschuh <linux@weissschuh.net>

Re: [PATCH v2 0/2] kbuild: propagate CONFIG_WERROR to resolve_btfids
Posted by Daniel Borkmann 1 year, 2 months ago
Hi Thomas,

On 11/26/24 10:17 PM, Thomas Weißschuh wrote:
> Use CONFIG_WERROR to also fail on warnings emitted by resolve_btfids.
> Allow the CI bots to prevent the introduction of new warnings.
> 
> This series currently depends on
> "[PATCH] bpf, lsm: Fix getlsmprop hooks BTF IDs" [0]
> 
> [0] https://lore.kernel.org/lkml/20241123-bpf_lsm_task_getsecid_obj-v1-1-0d0f94649e05@weissschuh.net/

Given this is a dependency, do you plan to follow up on [1]?

Thanks,
Daniel

   [1] https://lore.kernel.org/lkml/Z0TRc0A6Q8QUxNAe@google.com/
Re: [PATCH v2 0/2] kbuild: propagate CONFIG_WERROR to resolve_btfids
Posted by Thomas Weißschuh 1 year, 2 months ago
Hi Daniel,

On 2024-12-02 16:28:07+0100, Daniel Borkmann wrote:
> On 11/26/24 10:17 PM, Thomas Weißschuh wrote:
> > Use CONFIG_WERROR to also fail on warnings emitted by resolve_btfids.
> > Allow the CI bots to prevent the introduction of new warnings.
> > 
> > This series currently depends on
> > "[PATCH] bpf, lsm: Fix getlsmprop hooks BTF IDs" [0]
> > 
> > [0] https://lore.kernel.org/lkml/20241123-bpf_lsm_task_getsecid_obj-v1-1-0d0f94649e05@weissschuh.net/
> 
> Given this is a dependency, do you plan to follow up on [1]?

>   [1] https://lore.kernel.org/lkml/Z0TRc0A6Q8QUxNAe@google.com/

I did so in [2], which is already part of the BPF tree.

[2] https://lore.kernel.org/lkml/20241125-bpf_lsm_task_getsecid_obj-v2-1-c8395bde84e0@weissschuh.net/
Re: [PATCH v2 0/2] kbuild: propagate CONFIG_WERROR to resolve_btfids
Posted by Daniel Borkmann 1 year, 2 months ago
On 12/2/24 4:32 PM, Thomas Weißschuh wrote:
> On 2024-12-02 16:28:07+0100, Daniel Borkmann wrote:
>> On 11/26/24 10:17 PM, Thomas Weißschuh wrote:
>>> Use CONFIG_WERROR to also fail on warnings emitted by resolve_btfids.
>>> Allow the CI bots to prevent the introduction of new warnings.
>>>
>>> This series currently depends on
>>> "[PATCH] bpf, lsm: Fix getlsmprop hooks BTF IDs" [0]
>>>
>>> [0] https://lore.kernel.org/lkml/20241123-bpf_lsm_task_getsecid_obj-v1-1-0d0f94649e05@weissschuh.net/
>>
>> Given this is a dependency, do you plan to follow up on [1]?
> 
>>    [1] https://lore.kernel.org/lkml/Z0TRc0A6Q8QUxNAe@google.com/
> 
> I did so in [2], which is already part of the BPF tree.
> 
> [2] https://lore.kernel.org/lkml/20241125-bpf_lsm_task_getsecid_obj-v2-1-c8395bde84e0@weissschuh.net/

Perfect, nevermind then!