1. Patchew
  2. linux
  3. [PATCH 0/2] Adds SPMI bus, PMIC and peripherals for qcs8300-ride
  4. View patch

[PATCH 2/2] arm64: dts: qcom: qcs8300-ride: Enable PMIC peripherals

Tingguo Cheng posted 2 patches 1 year, 2 months ago
There is a newer version of this series
[PATCH 2/2] arm64: dts: qcom: qcs8300-ride: Enable PMIC peripherals
Posted by Tingguo Cheng 1 year, 2 months ago 
Enable PMIC and PMIC peripherals for qcs8300-ride board. The qcs8
300-ride uses 2 pmics(pmm8620au:0,pmm8650au:1) on the board, which
are variants of pmm8654au used on sa8775p/qcs9100 -ride(4x pmics).

Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
---
 arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
index 7eed19a694c39dbe791afb6a991db65acb37e597..9447efb9cd01654b74ec4c18dec58b1956ffe710 100644
--- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
@@ -9,6 +9,7 @@
 #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
 
 #include "qcs8300.dtsi"
+#include "sa8775p-pmics.dtsi"
 / {
 	model = "Qualcomm Technologies, Inc. QCS8300 Ride";
 	compatible = "qcom,qcs8300-ride", "qcom,qcs8300";
@@ -223,6 +224,28 @@ &gcc {
 		 <0>;
 };
 
+&pmm8654au_0_pon_resin{
+	linux,code = <KEY_VOLUMEDOWN>;
+
+	status = "okay";
+};
+
+&pmm8654au_2{
+	status = "disabled";
+};
+
+&pmm8654au_2_thermal{
+	status = "disabled";
+};
+
+&pmm8654au_3{
+	status = "disabled";
+};
+
+&pmm8654au_3_thermal{
+	status = "disabled";
+};
+
 &qupv3_id_0 {
 	status = "okay";
 };

-- 
2.34.1
Re: [PATCH 2/2] arm64: dts: qcom: qcs8300-ride: Enable PMIC peripherals
Posted by Konrad Dybcio 1 year, 2 months ago 
On 26.11.2024 10:35 AM, Tingguo Cheng wrote:
> Enable PMIC and PMIC peripherals for qcs8300-ride board. The qcs8
> 300-ride uses 2 pmics(pmm8620au:0,pmm8650au:1) on the board, which
> are variants of pmm8654au used on sa8775p/qcs9100 -ride(4x pmics).
> 
> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> index 7eed19a694c39dbe791afb6a991db65acb37e597..9447efb9cd01654b74ec4c18dec58b1956ffe710 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> @@ -9,6 +9,7 @@
>  #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>  
>  #include "qcs8300.dtsi"
> +#include "sa8775p-pmics.dtsi"
>  / {
>  	model = "Qualcomm Technologies, Inc. QCS8300 Ride";
>  	compatible = "qcom,qcs8300-ride", "qcom,qcs8300";
> @@ -223,6 +224,28 @@ &gcc {
>  		 <0>;
>  };
>  
> +&pmm8654au_0_pon_resin{
> +	linux,code = <KEY_VOLUMEDOWN>;
> +
> +	status = "okay";
> +};
> +
> +&pmm8654au_2{
> +	status = "disabled";
> +};
> +
> +&pmm8654au_2_thermal{
> +	status = "disabled";
> +};
> +
> +&pmm8654au_3{
> +	status = "disabled";
> +};
> +
> +&pmm8654au_3_thermal{
> +	status = "disabled";
> +};

Are all these PMICs absent?

Konrad
Re: [PATCH 2/2] arm64: dts: qcom: qcs8300-ride: Enable PMIC peripherals
Posted by Konrad Dybcio 1 year, 2 months ago 
On 29.11.2024 12:14 PM, Konrad Dybcio wrote:
> On 26.11.2024 10:35 AM, Tingguo Cheng wrote:
>> Enable PMIC and PMIC peripherals for qcs8300-ride board. The qcs8
>> 300-ride uses 2 pmics(pmm8620au:0,pmm8650au:1) on the board, which
>> are variants of pmm8654au used on sa8775p/qcs9100 -ride(4x pmics).
>>
>> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
>> ---
>>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++
>>  1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> index 7eed19a694c39dbe791afb6a991db65acb37e597..9447efb9cd01654b74ec4c18dec58b1956ffe710 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> @@ -9,6 +9,7 @@
>>  #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>>  
>>  #include "qcs8300.dtsi"
>> +#include "sa8775p-pmics.dtsi"
>>  / {
>>  	model = "Qualcomm Technologies, Inc. QCS8300 Ride";
>>  	compatible = "qcom,qcs8300-ride", "qcom,qcs8300";
>> @@ -223,6 +224,28 @@ &gcc {
>>  		 <0>;
>>  };
>>  
>> +&pmm8654au_0_pon_resin{
>> +	linux,code = <KEY_VOLUMEDOWN>;
>> +
>> +	status = "okay";
>> +};
>> +
>> +&pmm8654au_2{
>> +	status = "disabled";
>> +};
>> +
>> +&pmm8654au_2_thermal{
>> +	status = "disabled";
>> +};
>> +
>> +&pmm8654au_3{
>> +	status = "disabled";
>> +};
>> +
>> +&pmm8654au_3_thermal{
>> +	status = "disabled";
>> +};
> 
> Are all these PMICs absent?

OK I re-read the commit message..

Disabling a lot of things usually points to a backwards approach,
are there any other PMICs on board?

Konrad
Re: [PATCH 2/2] arm64: dts: qcom: qcs8300-ride: Enable PMIC peripherals
Posted by Tingguo Cheng 1 year, 1 month ago 

On 11/29/2024 7:30 PM, Konrad Dybcio wrote:
> On 29.11.2024 12:14 PM, Konrad Dybcio wrote:
>> On 26.11.2024 10:35 AM, Tingguo Cheng wrote:
>>> Enable PMIC and PMIC peripherals for qcs8300-ride board. The qcs8
>>> 300-ride uses 2 pmics(pmm8620au:0,pmm8650au:1) on the board, which
>>> are variants of pmm8654au used on sa8775p/qcs9100 -ride(4x pmics).
>>>
>>> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
>>> ---
>>>   arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++
>>>   1 file changed, 23 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>> index 7eed19a694c39dbe791afb6a991db65acb37e597..9447efb9cd01654b74ec4c18dec58b1956ffe710 100644
>>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>> @@ -9,6 +9,7 @@
>>>   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>>>   
>>>   #include "qcs8300.dtsi"
>>> +#include "sa8775p-pmics.dtsi"
>>>   / {
>>>   	model = "Qualcomm Technologies, Inc. QCS8300 Ride";
>>>   	compatible = "qcom,qcs8300-ride", "qcom,qcs8300";
>>> @@ -223,6 +224,28 @@ &gcc {
>>>   		 <0>;
>>>   };
>>>   
>>> +&pmm8654au_0_pon_resin{
>>> +	linux,code = <KEY_VOLUMEDOWN>;
>>> +
>>> +	status = "okay";
>>> +};
>>> +
>>> +&pmm8654au_2{
>>> +	status = "disabled";
>>> +};
>>> +
>>> +&pmm8654au_2_thermal{
>>> +	status = "disabled";
>>> +};
>>> +
>>> +&pmm8654au_3{
>>> +	status = "disabled";
>>> +};
>>> +
>>> +&pmm8654au_3_thermal{
>>> +	status = "disabled";
>>> +};
>>
>> Are all these PMICs absent?
 >
Yes, sa8775p/qcs9100 -ride devices get 4 pmics inside, but qcs8300-ride 
gets only 2 pmics inside(0 and 1). So pmm8654au_2 and pmm8654au_3 are 
going to be removed to align with the board configuration.
> 
> OK I re-read the commit message..
> 
> Disabling a lot of things usually points to a backwards approach,
> are there any other PMICs on board?
 >
No any other PMICs on board. There are only 2 PMICs on this type of 
board. And the 2 PMICs is the variant of the PMICs used on 
sa8775p/qcs9100 -ride. From this perspective, just like qcs615-ride 
device, so I reused the original xxx-pmics.dtsi to reflect the 
relationship of "variant".

> 
> Konrad

-- 
Thank you & BRs
Tingguo
Re: [PATCH 2/2] arm64: dts: qcom: qcs8300-ride: Enable PMIC peripherals
Posted by Dmitry Baryshkov 1 year, 2 months ago 
On Tue, Nov 26, 2024 at 05:35:06PM +0800, Tingguo Cheng wrote:
> Enable PMIC and PMIC peripherals for qcs8300-ride board. The qcs8
> 300-ride uses 2 pmics(pmm8620au:0,pmm8650au:1) on the board, which
> are variants of pmm8654au used on sa8775p/qcs9100 -ride(4x pmics).
> 
> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> index 7eed19a694c39dbe791afb6a991db65acb37e597..9447efb9cd01654b74ec4c18dec58b1956ffe710 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> @@ -9,6 +9,7 @@
>  #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>  
>  #include "qcs8300.dtsi"
> +#include "sa8775p-pmics.dtsi"
>  / {
>  	model = "Qualcomm Technologies, Inc. QCS8300 Ride";
>  	compatible = "qcom,qcs8300-ride", "qcom,qcs8300";
> @@ -223,6 +224,28 @@ &gcc {
>  		 <0>;
>  };
>  
> +&pmm8654au_0_pon_resin{

Missing space between the curve bracket (here and in all other entries).

> +	linux,code = <KEY_VOLUMEDOWN>;
> +
> +	status = "okay";
> +};
> +
> +&pmm8654au_2{
> +	status = "disabled";
> +};
> +
> +&pmm8654au_2_thermal{
> +	status = "disabled";

Does it work this way?

> +};
> +
> +&pmm8654au_3{
> +	status = "disabled";
> +};
> +
> +&pmm8654au_3_thermal{
> +	status = "disabled";
> +};
> +
>  &qupv3_id_0 {
>  	status = "okay";
>  };
> 
> -- 
> 2.34.1
> 

-- 
With best wishes
Dmitry
Re: [PATCH 2/2] arm64: dts: qcom: qcs8300-ride: Enable PMIC peripherals
Posted by Tingguo Cheng 1 year, 2 months ago 

On 11/26/2024 7:54 PM, Dmitry Baryshkov wrote:
> On Tue, Nov 26, 2024 at 05:35:06PM +0800, Tingguo Cheng wrote:
>> Enable PMIC and PMIC peripherals for qcs8300-ride board. The qcs8
>> 300-ride uses 2 pmics(pmm8620au:0,pmm8650au:1) on the board, which
>> are variants of pmm8654au used on sa8775p/qcs9100 -ride(4x pmics).
>>
>> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++
>>   1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> index 7eed19a694c39dbe791afb6a991db65acb37e597..9447efb9cd01654b74ec4c18dec58b1956ffe710 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> @@ -9,6 +9,7 @@
>>   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>>   
>>   #include "qcs8300.dtsi"
>> +#include "sa8775p-pmics.dtsi"
>>   / {
>>   	model = "Qualcomm Technologies, Inc. QCS8300 Ride";
>>   	compatible = "qcom,qcs8300-ride", "qcom,qcs8300";
>> @@ -223,6 +224,28 @@ &gcc {
>>   		 <0>;
>>   };
>>   
>> +&pmm8654au_0_pon_resin{
> 
> Missing space between the curve bracket (here and in all other entries).
Added a space here in next version:v2
> 
>> +	linux,code = <KEY_VOLUMEDOWN>;
>> +
>> +	status = "okay";
>> +};
>> +
>> +&pmm8654au_2{
>> +	status = "disabled";
>> +};
>> +
>> +&pmm8654au_2_thermal{
>> +	status = "disabled";
> 
> Does it work this way?
Yes, it works. functions are all working as expected. The result is the 
same as the way from writing the DTS nodes from scratch.
> 
>> +};
>> +
>> +&pmm8654au_3{
>> +	status = "disabled";
>> +};
>> +
>> +&pmm8654au_3_thermal{
>> +	status = "disabled";
>> +};
>> +
>>   &qupv3_id_0 {
>>   	status = "okay";
>>   };
>>
>> -- 
>> 2.34.1
>>
> 

-- 
Thank you & BRs
Tingguo

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.