[PATCH 1/2] arm64: dts: qcom: qcs8300: Adds SPMI support

Tingguo Cheng posted 2 patches 1 year, 2 months ago
There is a newer version of this series
[PATCH 1/2] arm64: dts: qcom: qcs8300: Adds SPMI support
Posted by Tingguo Cheng 1 year, 2 months ago
Add the SPMI bus arbiter node for QCS8300 SoC which connected
with PMICs on QCS8300 boards.

Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
---
 arch/arm64/boot/dts/qcom/qcs8300.dtsi | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs8300.dtsi b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
index 2c35f96c3f289d5e2e57e0e30ef5e17cd1286188..03bf72d6ec5c9ec92f6f53df9253c8c5953e13c4 100644
--- a/arch/arm64/boot/dts/qcom/qcs8300.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
@@ -939,6 +939,28 @@ IPCC_MPROC_SIGNAL_GLINK_QMP
 			#clock-cells = <0>;
 		};
 
+		spmi_bus: spmi@c440000 {
+			compatible = "qcom,spmi-pmic-arb";
+			reg = <0x0 0x0c440000 0x0 0x1100>,
+			      <0x0 0x0c600000 0x0 0x2000000>,
+			      <0x0 0x0e600000 0x0 0x100000>,
+			      <0x0 0x0e700000 0x0 0xa0000>,
+			      <0x0 0x0c40a000 0x0 0x26000>;
+			reg-names = "core",
+				    "chnls",
+				    "obsrvr",
+				    "intr",
+				    "cnfg";
+			qcom,channel = <0>;
+			qcom,ee = <0>;
+			interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "periph_irq";
+			interrupt-controller;
+			#interrupt-cells = <4>;
+			#address-cells = <2>;
+			#size-cells = <0>;
+		};
+
 		tlmm: pinctrl@f100000 {
 			compatible = "qcom,qcs8300-tlmm";
 			reg = <0x0 0x0f100000 0x0 0x300000>;

-- 
2.34.1
Re: [PATCH 1/2] arm64: dts: qcom: qcs8300: Adds SPMI support
Posted by Dmitry Baryshkov 1 year, 2 months ago
On Tue, Nov 26, 2024 at 05:35:05PM +0800, Tingguo Cheng wrote:
> Add the SPMI bus arbiter node for QCS8300 SoC which connected
> with PMICs on QCS8300 boards.

Could you please comment, what is the version of the SPMI controller /
arbiter?

> 
> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/qcs8300.dtsi | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs8300.dtsi b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
> index 2c35f96c3f289d5e2e57e0e30ef5e17cd1286188..03bf72d6ec5c9ec92f6f53df9253c8c5953e13c4 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8300.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
> @@ -939,6 +939,28 @@ IPCC_MPROC_SIGNAL_GLINK_QMP
>  			#clock-cells = <0>;
>  		};
>  
> +		spmi_bus: spmi@c440000 {
> +			compatible = "qcom,spmi-pmic-arb";
> +			reg = <0x0 0x0c440000 0x0 0x1100>,
> +			      <0x0 0x0c600000 0x0 0x2000000>,
> +			      <0x0 0x0e600000 0x0 0x100000>,
> +			      <0x0 0x0e700000 0x0 0xa0000>,
> +			      <0x0 0x0c40a000 0x0 0x26000>;
> +			reg-names = "core",
> +				    "chnls",
> +				    "obsrvr",
> +				    "intr",
> +				    "cnfg";
> +			qcom,channel = <0>;
> +			qcom,ee = <0>;
> +			interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-names = "periph_irq";
> +			interrupt-controller;
> +			#interrupt-cells = <4>;
> +			#address-cells = <2>;
> +			#size-cells = <0>;
> +		};
> +
>  		tlmm: pinctrl@f100000 {
>  			compatible = "qcom,qcs8300-tlmm";
>  			reg = <0x0 0x0f100000 0x0 0x300000>;
> 
> -- 
> 2.34.1
> 

-- 
With best wishes
Dmitry
Re: [PATCH 1/2] arm64: dts: qcom: qcs8300: Adds SPMI support
Posted by Tingguo Cheng 1 year, 2 months ago

On 11/26/2024 7:50 PM, Dmitry Baryshkov wrote:
> On Tue, Nov 26, 2024 at 05:35:05PM +0800, Tingguo Cheng wrote:
>> Add the SPMI bus arbiter node for QCS8300 SoC which connected
>> with PMICs on QCS8300 boards.
> 
> Could you please comment, what is the version of the SPMI controller /
> arbiter?
Sure, let me add the version information in the commit message.
> 
>>
>> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/qcs8300.dtsi | 22 ++++++++++++++++++++++
>>   1 file changed, 22 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300.dtsi b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
>> index 2c35f96c3f289d5e2e57e0e30ef5e17cd1286188..03bf72d6ec5c9ec92f6f53df9253c8c5953e13c4 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs8300.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
>> @@ -939,6 +939,28 @@ IPCC_MPROC_SIGNAL_GLINK_QMP
>>   			#clock-cells = <0>;
>>   		};
>>   
>> +		spmi_bus: spmi@c440000 {
>> +			compatible = "qcom,spmi-pmic-arb";
>> +			reg = <0x0 0x0c440000 0x0 0x1100>,
>> +			      <0x0 0x0c600000 0x0 0x2000000>,
>> +			      <0x0 0x0e600000 0x0 0x100000>,
>> +			      <0x0 0x0e700000 0x0 0xa0000>,
>> +			      <0x0 0x0c40a000 0x0 0x26000>;
>> +			reg-names = "core",
>> +				    "chnls",
>> +				    "obsrvr",
>> +				    "intr",
>> +				    "cnfg";
>> +			qcom,channel = <0>;
>> +			qcom,ee = <0>;
>> +			interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>;
>> +			interrupt-names = "periph_irq";
>> +			interrupt-controller;
>> +			#interrupt-cells = <4>;
>> +			#address-cells = <2>;
>> +			#size-cells = <0>;
>> +		};
>> +
>>   		tlmm: pinctrl@f100000 {
>>   			compatible = "qcom,qcs8300-tlmm";
>>   			reg = <0x0 0x0f100000 0x0 0x300000>;
>>
>> -- 
>> 2.34.1
>>
> 

-- 
Thank you & BRs
Tingguo
Re: [PATCH 1/2] arm64: dts: qcom: qcs8300: Adds SPMI support
Posted by Dmitry Baryshkov 1 year, 2 months ago
On Thu, Nov 28, 2024 at 03:55:31PM +0800, Tingguo Cheng wrote:
> 
> 
> On 11/26/2024 7:50 PM, Dmitry Baryshkov wrote:
> > On Tue, Nov 26, 2024 at 05:35:05PM +0800, Tingguo Cheng wrote:
> > > Add the SPMI bus arbiter node for QCS8300 SoC which connected
> > > with PMICs on QCS8300 boards.
> > 
> > Could you please comment, what is the version of the SPMI controller /
> > arbiter?
> Sure, let me add the version information in the commit message.

Answering here would have been easier to follow.

> > 
> > > 
> > > Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
> > > ---
> > >   arch/arm64/boot/dts/qcom/qcs8300.dtsi | 22 ++++++++++++++++++++++
> > >   1 file changed, 22 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/qcom/qcs8300.dtsi b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
> > > index 2c35f96c3f289d5e2e57e0e30ef5e17cd1286188..03bf72d6ec5c9ec92f6f53df9253c8c5953e13c4 100644
> > > --- a/arch/arm64/boot/dts/qcom/qcs8300.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
> > > @@ -939,6 +939,28 @@ IPCC_MPROC_SIGNAL_GLINK_QMP
> > >   			#clock-cells = <0>;
> > >   		};
> > > +		spmi_bus: spmi@c440000 {
> > > +			compatible = "qcom,spmi-pmic-arb";
> > > +			reg = <0x0 0x0c440000 0x0 0x1100>,
> > > +			      <0x0 0x0c600000 0x0 0x2000000>,
> > > +			      <0x0 0x0e600000 0x0 0x100000>,
> > > +			      <0x0 0x0e700000 0x0 0xa0000>,
> > > +			      <0x0 0x0c40a000 0x0 0x26000>;
> > > +			reg-names = "core",
> > > +				    "chnls",
> > > +				    "obsrvr",
> > > +				    "intr",
> > > +				    "cnfg";
> > > +			qcom,channel = <0>;
> > > +			qcom,ee = <0>;
> > > +			interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>;
> > > +			interrupt-names = "periph_irq";
> > > +			interrupt-controller;
> > > +			#interrupt-cells = <4>;
> > > +			#address-cells = <2>;
> > > +			#size-cells = <0>;
> > > +		};
> > > +
> > >   		tlmm: pinctrl@f100000 {
> > >   			compatible = "qcom,qcs8300-tlmm";
> > >   			reg = <0x0 0x0f100000 0x0 0x300000>;
> > > 
> > > -- 
> > > 2.34.1
> > > 
> > 
> 
> -- 
> Thank you & BRs
> Tingguo
> 

-- 
With best wishes
Dmitry
Re: [PATCH 1/2] arm64: dts: qcom: qcs8300: Adds SPMI support
Posted by Konrad Dybcio 1 year, 2 months ago
On 28.11.2024 1:56 PM, Dmitry Baryshkov wrote:
> On Thu, Nov 28, 2024 at 03:55:31PM +0800, Tingguo Cheng wrote:
>>
>>
>> On 11/26/2024 7:50 PM, Dmitry Baryshkov wrote:
>>> On Tue, Nov 26, 2024 at 05:35:05PM +0800, Tingguo Cheng wrote:
>>>> Add the SPMI bus arbiter node for QCS8300 SoC which connected
>>>> with PMICs on QCS8300 boards.
>>>
>>> Could you please comment, what is the version of the SPMI controller /
>>> arbiter?
>> Sure, let me add the version information in the commit message.
> 
> Answering here would have been easier to follow.

Computer suggests v5.2.0

Konrad