[PATCH-next] mailbox: ti-msgmgr: Remove redundant logical check

Advait Dhamorikar posted 1 patch 1 year, 2 months ago
drivers/mailbox/ti-msgmgr.c | 2 --
1 file changed, 2 deletions(-)
[PATCH-next] mailbox: ti-msgmgr: Remove redundant logical check
Posted by Advait Dhamorikar 1 year, 2 months ago
Remove redundant `WARN_ON(!inst)` check as `container_of` will 
always calculate the address of `ti_msgmgr_inst` if *mbox is valid.
The indicated dead code may have performed some action; that action 
will never occur.

Signed-off-by: Advait Dhamorikar <advaitdhamorikar@gmail.com>
---
 drivers/mailbox/ti-msgmgr.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/mailbox/ti-msgmgr.c b/drivers/mailbox/ti-msgmgr.c
index 8eb8df8d95a4..b5fb01327d80 100644
--- a/drivers/mailbox/ti-msgmgr.c
+++ b/drivers/mailbox/ti-msgmgr.c
@@ -580,8 +580,6 @@ static struct mbox_chan *ti_msgmgr_of_xlate(struct mbox_controller *mbox,
 	int i, ncells;
 
 	inst = container_of(mbox, struct ti_msgmgr_inst, mbox);
-	if (WARN_ON(!inst))
-		return ERR_PTR(-EINVAL);
 
 	d = inst->desc;
 
-- 
2.34.1