[PATCH 1/2] arm64/acpi: panic when failed to init acpi table with acpi=force option

Yeoreum Yun posted 2 patches 1 year, 2 months ago
There is a newer version of this series
[PATCH 1/2] arm64/acpi: panic when failed to init acpi table with acpi=force option
Posted by Yeoreum Yun 1 year, 2 months ago
when the acpi=force option is used,
the system does not fall back to the device tree (DT).
If it fails to initialize the ACPI table, it cannot proceed further.
In such cases, the system should invoke panic() to avoid contradicting
the user's explicit intent, as failing or
proceeding with unintended behavior would violate their wishes.

Signed-off-by: Yeoreum Yun <yeoreum.yun@arm.com>
---
 arch/arm64/kernel/acpi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c
index e6f66491fbe9..efdf24ed5c3e 100644
--- a/arch/arm64/kernel/acpi.c
+++ b/arch/arm64/kernel/acpi.c
@@ -225,6 +225,8 @@ void __init acpi_boot_table_init(void)
 		pr_err("Failed to init ACPI tables\n");
 		if (!param_acpi_force)
 			disable_acpi();
+		else
+			panic("Failed to boot with ACPI tables\n");
 	}

 done:
--
LEVI:{C3F47F37-75D8-414A-A8BA-3980EC8A46D7}
Re: [PATCH 1/2] arm64/acpi: panic when failed to init acpi table with acpi=force option
Posted by Mark Brown 1 year, 2 months ago
On Mon, Nov 25, 2024 at 02:58:47PM +0000, Yeoreum Yun wrote:

> when the acpi=force option is used,
> the system does not fall back to the device tree (DT).
> If it fails to initialize the ACPI table, it cannot proceed further.
> In such cases, the system should invoke panic() to avoid contradicting
> the user's explicit intent, as failing or
> proceeding with unintended behavior would violate their wishes.

This makes sense to me:

Reviewed-by: Mark Brown <broonie@kernel.org>